fix: Make the application of an ulimit to open fds configurable. #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New property `set_ulimit_fds` to disable ulimiting. Defaults to true, activating the ulimit for standard behaviour. Origin ticket: cloudfoundry-incubator/kubecf#504
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/172774519 The labels on this github issue will be updated when the story is started. |
cwlbraa
reviewed
May 12, 2020
|
@andreas-kupries can you please address @cwlbraa 's comments? |
|
@viovanov Yes. Apologies for missing them when they were made. |
7 tasks
|
Sigh. Embarassing. See cloudfoundry-incubator/kubecf#1040 for the PR which has now removed these patches from kubecf itself. Closing with apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New property
set_ulimit_fdsto disable ulimiting.Defaults to true, activating the ulimit for standard behaviour.
The change allows SUSE to disable the application of the limit in their containerization (where it interferes) without having to patch system sources. After the change this can be done properly via ops files changing the relevant properties.
Origin ticket: cloudfoundry-incubator/kubecf#504
Origin ticket: cloudfoundry-incubator/kubecf#505
See also cloudfoundry/diego-release#512
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite