Skip to content

Conversation

@Benjamintf1
Copy link
Member

  • do not render prom scraper config when syslog server or nozzle is not run
  • bringing up to date with new patterns for optional prom scraping in new releases of loggregator-agent and metrics-discovery

Signed-off-by: Ben Fuller [email protected]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

- do not render prom scraper config when syslog server or nozzle is not run
- bringing up to date with new patterns for optional prom scraping in new releases of loggregator-agent and metrics-discovery

Signed-off-by: Ben Fuller <[email protected]>
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@Benjamintf1 Benjamintf1 merged commit 6dc988e into v2.8.x Mar 3, 2022
@Benjamintf1 Benjamintf1 deleted the fix-prom-scraper-config-2.8.x branch March 3, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants