Skip to content

Conversation

@mkocher
Copy link
Member

@mkocher mkocher commented Mar 7, 2022

Description

Update Readme. Remove some outdated stuff and add more explanations for humans.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

Benjamintf1
Benjamintf1 previously approved these changes Mar 7, 2022
Copy link
Member

@Benjamintf1 Benjamintf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Benjamintf1
Copy link
Member

hmmm, lol, that didn't need to be integration tested.

ctlong
ctlong previously approved these changes Mar 8, 2022
Copy link
Member

@ctlong ctlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: Rebecca Roberts <[email protected]>
@Benjamintf1 Benjamintf1 dismissed stale reviews from ctlong and themself via f86b051 March 8, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants