generate local county mapping from CHNG spreadsheet #1803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krivard
suggested changes
Mar 3, 2023
Contributor
krivard
left a comment
krivard
left a comment
There was a problem hiding this comment.
nice refactor, but it might be too nice -- we should resolve the already-exists handling before merging.
dshemetov
requested changes
Mar 3, 2023
Contributor
dshemetov
left a comment
dshemetov
left a comment
There was a problem hiding this comment.
Second Katie's comment. Should be g2g after!
We can't rely on the component counties of a group being listed individually, so reconstruct those fields ourselves based on the concatenated `fips_list` field. Split by the separator (pipe `|`) and save each result to a new column.
…geomapper/chng-fips-map-generation
Co-authored-by: Dmitry Shemetov <[email protected]>
Contributor
Author
|
@korlaxxalrok This is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case CHNG makes changes to their county mappings, include the code that takes the Google spreadsheet, assigns group numbers, and saves locally. Be careful to keep from reusing group numbers within a state. Doing so would make historical data uninterpretable or difficult to use/document.
Changelog
geo_data_proc.py