Merge pull request #244 from cmu-delphi/ds/covid-hosp-na-bug

fix: NAs in int field bug

Author: dshemetov

DESCRIPTION

@@ -39,7 +39,7 @@ Imports:
     tibble,
     usethis,
     xml2
-RoxygenNote: 7.3.0
+RoxygenNote: 7.3.1
 Suggests:
     dplyr,
     ggplot2,

NEWS.md

@@ -22,6 +22,7 @@
 - Fix some errors from passing "" as a key.
 - `pvt_twitter` and `pub_wiki` now use `time_type` and `time_values` args instead of mutually exclusive `dates` and `epiweeks` (#236). This matches the interface of the `pub_covidcast` endpoint.
 - All endpoints now support the use of "\*" as a wildcard to fetch all dates or epiweeks (#234).
+- Fixed bug with NAs when parsing ints (#243).
 
 # epidatr 1.0.0
 

R/model.R

@@ -179,7 +179,7 @@ parse_value <- function(info, value, disable_date_parsing = FALSE) {
   } else if (info$type == "int") {
     # Int doesn't have enough capacity to store some weekly `pub_wiki` values.
     value <- as.double(value)
-    if (any(value != round(value))) {
+    if (any(na.omit(value != round(value)))) {
       cli::cli_warn(
         c(
           "Values in {info$name} were expected to be integers but contain a decimal component",

tests/testthat/test-model.R

@@ -123,6 +123,17 @@ test_that("parse_data_frame warns when df contains int values with decimal compo
   )
 })
 
+test_that("parse_value can handle NA/NULL values in an int field", {
+  info <- create_epidata_field_info(
+    name = "test",
+    type = "int"
+  )
+  expect_warning(
+    parse_value(info, c(1, 1.5, NA, NULL)),
+    class = "epidatr__int_nonzero_decimal_digits"
+  )
+})
+
 test_that("parse_api_date accepts str and int input", {
   expect_identical(parse_api_date("20200101"), as.Date("2020-01-01"))
   expect_identical(parse_api_date(20200101), as.Date("2020-01-01"))