Skip to content

Conversation

@dshemetov
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

So our automated CI actions have felt more annoying to me than helpful lately. Here's a quick change to make these actions opt-in, rather than default on:

  • Remove the automated styler command that tries to fix stuff (and often breaks if you push too many commits at once)
  • Replace it with the "pr-commands" workflow, which similar to the "/preview-docs" command, will run styler or document in response to "/style" and "/document" (this action is preferred in tidyverse/dplyr for instance)

If it seems like a good idea, let's do it, if not, feel free too close, probably not worth too much deliberation.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@dshemetov dshemetov requested a review from dajmcdon as a code owner March 24, 2025 20:41
@dajmcdon dajmcdon merged commit 5372480 into dev Mar 25, 2025
1 check passed
@dshemetov dshemetov deleted the ds/ci branch March 25, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants