Skip to content

Commit 4e3dffa

Browse files
pull[bot]pull[bot]
committed
[react-native] Pull up enableFastAddPropertiesInDiffing check (facebook#33043)
## Summary We don't need the isArray check for this experiment, as `fastAddProperties` already does the same. Also renaming slowAddProperties to make it clearer we can fully remove this codepath once fastAddProperties is fully rolled out. ## How did you test this change? ``` yarn test packages/react-native-renderer -r=xplat --variant=true ``` DiffTrain build for [0038c50](facebook@0038c50)
1 parent 5643dca commit 4e3dffa

23 files changed

+110
-100
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-3ef31d19-20250422
1+
19.2.0-native-fb-0038c501-20250429

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d4a49cc2733833ed94561a8032a6faad>>
10+
* @generated SignedSource<<ad23a59b46a733dcb0df365ac961b559>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-3ef31d19-20250422";
407+
exports.version = "19.2.0-native-fb-0038c501-20250429";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d2bab8536f4680d22758a6c9e6bf0ef5>>
10+
* @generated SignedSource<<0174cc70e7e9694eec9f18abeb2f5b19>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-3ef31d19-20250422";
206+
exports.version = "19.2.0-native-fb-0038c501-20250429";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d2bab8536f4680d22758a6c9e6bf0ef5>>
10+
* @generated SignedSource<<0174cc70e7e9694eec9f18abeb2f5b19>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-3ef31d19-20250422";
206+
exports.version = "19.2.0-native-fb-0038c501-20250429";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9d13782b98a9874b7d41d61be121c254>>
10+
* @generated SignedSource<<1960f570368733d578b6de81a3a6772c>>
1111
*/
1212

1313
/*
@@ -26236,11 +26236,11 @@ __DEV__ &&
2623626236
};
2623726237
(function () {
2623826238
var isomorphicReactPackageVersion = React.version;
26239-
if ("19.2.0-native-fb-3ef31d19-20250422" !== isomorphicReactPackageVersion)
26239+
if ("19.2.0-native-fb-0038c501-20250429" !== isomorphicReactPackageVersion)
2624026240
throw Error(
2624126241
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2624226242
(isomorphicReactPackageVersion +
26243-
"\n - react-dom: 19.2.0-native-fb-3ef31d19-20250422\nLearn more: https://react.dev/warnings/version-mismatch")
26243+
"\n - react-dom: 19.2.0-native-fb-0038c501-20250429\nLearn more: https://react.dev/warnings/version-mismatch")
2624426244
);
2624526245
})();
2624626246
("function" === typeof Map &&
@@ -26277,10 +26277,10 @@ __DEV__ &&
2627726277
!(function () {
2627826278
var internals = {
2627926279
bundleType: 1,
26280-
version: "19.2.0-native-fb-3ef31d19-20250422",
26280+
version: "19.2.0-native-fb-0038c501-20250429",
2628126281
rendererPackageName: "react-dom",
2628226282
currentDispatcherRef: ReactSharedInternals,
26283-
reconcilerVersion: "19.2.0-native-fb-3ef31d19-20250422"
26283+
reconcilerVersion: "19.2.0-native-fb-0038c501-20250429"
2628426284
};
2628526285
internals.overrideHookState = overrideHookState;
2628626286
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -26424,5 +26424,5 @@ __DEV__ &&
2642426424
listenToAllSupportedEvents(container);
2642526425
return new ReactDOMHydrationRoot(initialChildren);
2642626426
};
26427-
exports.version = "19.2.0-native-fb-3ef31d19-20250422";
26427+
exports.version = "19.2.0-native-fb-0038c501-20250429";
2642826428
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<cade4038c3833f45892d864627d327de>>
10+
* @generated SignedSource<<638434daf1c86509eea1173db6df4fc2>>
1111
*/
1212

1313
/*
@@ -16334,14 +16334,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1633416334
};
1633516335
var isomorphicReactPackageVersion$jscomp$inline_1838 = React.version;
1633616336
if (
16337-
"19.2.0-native-fb-3ef31d19-20250422" !==
16337+
"19.2.0-native-fb-0038c501-20250429" !==
1633816338
isomorphicReactPackageVersion$jscomp$inline_1838
1633916339
)
1634016340
throw Error(
1634116341
formatProdErrorMessage(
1634216342
527,
1634316343
isomorphicReactPackageVersion$jscomp$inline_1838,
16344-
"19.2.0-native-fb-3ef31d19-20250422"
16344+
"19.2.0-native-fb-0038c501-20250429"
1634516345
)
1634616346
);
1634716347
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16363,10 +16363,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1636316363
};
1636416364
var internals$jscomp$inline_2316 = {
1636516365
bundleType: 0,
16366-
version: "19.2.0-native-fb-3ef31d19-20250422",
16366+
version: "19.2.0-native-fb-0038c501-20250429",
1636716367
rendererPackageName: "react-dom",
1636816368
currentDispatcherRef: ReactSharedInternals,
16369-
reconcilerVersion: "19.2.0-native-fb-3ef31d19-20250422"
16369+
reconcilerVersion: "19.2.0-native-fb-0038c501-20250429"
1637016370
};
1637116371
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1637216372
var hook$jscomp$inline_2317 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16470,4 +16470,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1647016470
listenToAllSupportedEvents(container);
1647116471
return new ReactDOMHydrationRoot(initialChildren);
1647216472
};
16473-
exports.version = "19.2.0-native-fb-3ef31d19-20250422";
16473+
exports.version = "19.2.0-native-fb-0038c501-20250429";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9d7709d7f037e02c11b3263d8352d7a1>>
10+
* @generated SignedSource<<692b0056c27fb8495e61537b77520b77>>
1111
*/
1212

1313
/*
@@ -17043,14 +17043,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1704317043
};
1704417044
var isomorphicReactPackageVersion$jscomp$inline_1941 = React.version;
1704517045
if (
17046-
"19.2.0-native-fb-3ef31d19-20250422" !==
17046+
"19.2.0-native-fb-0038c501-20250429" !==
1704717047
isomorphicReactPackageVersion$jscomp$inline_1941
1704817048
)
1704917049
throw Error(
1705017050
formatProdErrorMessage(
1705117051
527,
1705217052
isomorphicReactPackageVersion$jscomp$inline_1941,
17053-
"19.2.0-native-fb-3ef31d19-20250422"
17053+
"19.2.0-native-fb-0038c501-20250429"
1705417054
)
1705517055
);
1705617056
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17072,10 +17072,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1707217072
};
1707317073
var internals$jscomp$inline_1948 = {
1707417074
bundleType: 0,
17075-
version: "19.2.0-native-fb-3ef31d19-20250422",
17075+
version: "19.2.0-native-fb-0038c501-20250429",
1707617076
rendererPackageName: "react-dom",
1707717077
currentDispatcherRef: ReactSharedInternals,
17078-
reconcilerVersion: "19.2.0-native-fb-3ef31d19-20250422",
17078+
reconcilerVersion: "19.2.0-native-fb-0038c501-20250429",
1707917079
getLaneLabelMap: function () {
1708017080
for (
1708117081
var map = new Map(), lane = 1, index$304 = 0;
@@ -17194,4 +17194,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1719417194
listenToAllSupportedEvents(container);
1719517195
return new ReactDOMHydrationRoot(initialChildren);
1719617196
};
17197-
exports.version = "19.2.0-native-fb-3ef31d19-20250422";
17197+
exports.version = "19.2.0-native-fb-0038c501-20250429";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<df0856e30e200f776f17366652f15b1b>>
10+
* @generated SignedSource<<c3937861fd3cfe1bbb79f461ca397859>>
1111
*/
1212

1313
/*
@@ -26297,11 +26297,11 @@ __DEV__ &&
2629726297
};
2629826298
(function () {
2629926299
var isomorphicReactPackageVersion = React.version;
26300-
if ("19.2.0-native-fb-3ef31d19-20250422" !== isomorphicReactPackageVersion)
26300+
if ("19.2.0-native-fb-0038c501-20250429" !== isomorphicReactPackageVersion)
2630126301
throw Error(
2630226302
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2630326303
(isomorphicReactPackageVersion +
26304-
"\n - react-dom: 19.2.0-native-fb-3ef31d19-20250422\nLearn more: https://react.dev/warnings/version-mismatch")
26304+
"\n - react-dom: 19.2.0-native-fb-0038c501-20250429\nLearn more: https://react.dev/warnings/version-mismatch")
2630526305
);
2630626306
})();
2630726307
("function" === typeof Map &&
@@ -26338,10 +26338,10 @@ __DEV__ &&
2633826338
!(function () {
2633926339
var internals = {
2634026340
bundleType: 1,
26341-
version: "19.2.0-native-fb-3ef31d19-20250422",
26341+
version: "19.2.0-native-fb-0038c501-20250429",
2634226342
rendererPackageName: "react-dom",
2634326343
currentDispatcherRef: ReactSharedInternals,
26344-
reconcilerVersion: "19.2.0-native-fb-3ef31d19-20250422"
26344+
reconcilerVersion: "19.2.0-native-fb-0038c501-20250429"
2634526345
};
2634626346
internals.overrideHookState = overrideHookState;
2634726347
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -26801,7 +26801,7 @@ __DEV__ &&
2680126801
exports.useFormStatus = function () {
2680226802
return resolveDispatcher().useHostTransitionStatus();
2680326803
};
26804-
exports.version = "19.2.0-native-fb-3ef31d19-20250422";
26804+
exports.version = "19.2.0-native-fb-0038c501-20250429";
2680526805
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2680626806
"function" ===
2680726807
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<f827b5a5d294f8e9379461106fec2436>>
10+
* @generated SignedSource<<567daf56c9bec1598de3d0108311e62b>>
1111
*/
1212

1313
/*
@@ -16345,14 +16345,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1634516345
};
1634616346
var isomorphicReactPackageVersion$jscomp$inline_1839 = React.version;
1634716347
if (
16348-
"19.2.0-native-fb-3ef31d19-20250422" !==
16348+
"19.2.0-native-fb-0038c501-20250429" !==
1634916349
isomorphicReactPackageVersion$jscomp$inline_1839
1635016350
)
1635116351
throw Error(
1635216352
formatProdErrorMessage(
1635316353
527,
1635416354
isomorphicReactPackageVersion$jscomp$inline_1839,
16355-
"19.2.0-native-fb-3ef31d19-20250422"
16355+
"19.2.0-native-fb-0038c501-20250429"
1635616356
)
1635716357
);
1635816358
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16374,10 +16374,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1637416374
};
1637516375
var internals$jscomp$inline_2319 = {
1637616376
bundleType: 0,
16377-
version: "19.2.0-native-fb-3ef31d19-20250422",
16377+
version: "19.2.0-native-fb-0038c501-20250429",
1637816378
rendererPackageName: "react-dom",
1637916379
currentDispatcherRef: ReactSharedInternals,
16380-
reconcilerVersion: "19.2.0-native-fb-3ef31d19-20250422"
16380+
reconcilerVersion: "19.2.0-native-fb-0038c501-20250429"
1638116381
};
1638216382
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1638316383
var hook$jscomp$inline_2320 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16635,4 +16635,4 @@ exports.useFormState = function (action, initialState, permalink) {
1663516635
exports.useFormStatus = function () {
1663616636
return ReactSharedInternals.H.useHostTransitionStatus();
1663716637
};
16638-
exports.version = "19.2.0-native-fb-3ef31d19-20250422";
16638+
exports.version = "19.2.0-native-fb-0038c501-20250429";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<1f40b96c85aae18f9df88e7417de3a95>>
10+
* @generated SignedSource<<d35da6dbcc731e043d4e98913e9ecd39>>
1111
*/
1212

1313
/*
@@ -17058,14 +17058,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1705817058
};
1705917059
var isomorphicReactPackageVersion$jscomp$inline_1942 = React.version;
1706017060
if (
17061-
"19.2.0-native-fb-3ef31d19-20250422" !==
17061+
"19.2.0-native-fb-0038c501-20250429" !==
1706217062
isomorphicReactPackageVersion$jscomp$inline_1942
1706317063
)
1706417064
throw Error(
1706517065
formatProdErrorMessage(
1706617066
527,
1706717067
isomorphicReactPackageVersion$jscomp$inline_1942,
17068-
"19.2.0-native-fb-3ef31d19-20250422"
17068+
"19.2.0-native-fb-0038c501-20250429"
1706917069
)
1707017070
);
1707117071
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17087,10 +17087,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1708717087
};
1708817088
var internals$jscomp$inline_1949 = {
1708917089
bundleType: 0,
17090-
version: "19.2.0-native-fb-3ef31d19-20250422",
17090+
version: "19.2.0-native-fb-0038c501-20250429",
1709117091
rendererPackageName: "react-dom",
1709217092
currentDispatcherRef: ReactSharedInternals,
17093-
reconcilerVersion: "19.2.0-native-fb-3ef31d19-20250422",
17093+
reconcilerVersion: "19.2.0-native-fb-0038c501-20250429",
1709417094
getLaneLabelMap: function () {
1709517095
for (
1709617096
var map = new Map(), lane = 1, index$304 = 0;
@@ -17363,7 +17363,7 @@ exports.useFormState = function (action, initialState, permalink) {
1736317363
exports.useFormStatus = function () {
1736417364
return ReactSharedInternals.H.useHostTransitionStatus();
1736517365
};
17366-
exports.version = "19.2.0-native-fb-3ef31d19-20250422";
17366+
exports.version = "19.2.0-native-fb-0038c501-20250429";
1736717367
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1736817368
"function" ===
1736917369
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)