Ch. 14 and 15 Problems #16

JJ27 · 2020-09-27T20:29:33Z

Ch. 14 - File I/O Medium Difficulty Lexicographical Problem

Ch. 15 - Interfaces High Difficulty Problem

Josh Joseph

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2020-09-27T20:30:46Z

src/com/codefortomorrow/advanced/chapter15/practice/MeasurableProblem.java

@@ -0,0 +1,24 @@
+package com.codefortomorrow.advanced.chapter15.practice;
+/*


[reviewdog] _{reported by reviewdog 🐶}
'/*' should be separated from previous statement.

github-actions · 2020-09-27T20:30:46Z

src/com/codefortomorrow/advanced/chapter15/practice/MeasurableProblem.java

+
+Problem adapted from Java SE 9 Textbook
+*/
+public class MeasurableProblem{


[reviewdog] _{reported by reviewdog 🐶}
WhitespaceAround: '{' is not preceded with whitespace.

github-actions · 2020-09-27T20:30:46Z

src/com/codefortomorrow/advanced/chapter15/practice/MeasurableProblem.java

+Problem adapted from Java SE 9 Textbook
+*/
+public class MeasurableProblem{
+  public static void main(String[] args){


[reviewdog] _{reported by reviewdog 🐶}
'method def modifier' has incorrect indentation level 2, expected level should be 4.

github-actions · 2020-09-27T20:30:47Z

src/com/codefortomorrow/advanced/chapter15/practice/MeasurableProblem.java

+public class MeasurableProblem{
+  public static void main(String[] args){
+    //Add testing code
+  }


[reviewdog] _{reported by reviewdog 🐶}
'method def rcurly' has incorrect indentation level 2, expected level should be 4.

github-actions · 2020-09-27T20:30:47Z

src/com/codefortomorrow/advanced/chapter15/practice/MeasurableProblem.java

+    //Add testing code
+  }
+}
+interface Measurable{


[reviewdog] _{reported by reviewdog 🐶}
'INTERFACE_DEF' should be separated from previous statement.

github-actions · 2020-09-27T20:30:51Z

src/com/codefortomorrow/advanced/chapter15/solutions/MeasurableProblem.java

+    System.out.println("Smallest: " + test.smallest(students));
+  }
+}
+interface Measurable{


[reviewdog] _{reported by reviewdog 🐶}
WhitespaceAround: '{' is not preceded with whitespace.

github-actions · 2020-09-27T20:30:51Z

src/com/codefortomorrow/advanced/chapter15/solutions/MeasurableProblem.java

+  }
+}
+interface Measurable{
+  abstract double average(Object[] students);


[reviewdog] _{reported by reviewdog 🐶}
'method def modifier' has incorrect indentation level 2, expected level should be 4.

github-actions · 2020-09-27T20:30:51Z

src/com/codefortomorrow/advanced/chapter15/solutions/MeasurableProblem.java

+}
+interface Measurable{
+  abstract double average(Object[] students);
+  abstract String largest(Object[] students);


[reviewdog] _{reported by reviewdog 🐶}
'METHOD_DEF' should be separated from previous statement.

github-actions · 2020-09-27T20:30:52Z

src/com/codefortomorrow/advanced/chapter15/solutions/MeasurableProblem.java

+}
+interface Measurable{
+  abstract double average(Object[] students);
+  abstract String largest(Object[] students);


[reviewdog] _{reported by reviewdog 🐶}
'method def modifier' has incorrect indentation level 2, expected level should be 4.

github-actions · 2020-09-27T20:30:52Z

src/com/codefortomorrow/advanced/chapter15/solutions/MeasurableProblem.java

+interface Measurable{
+  abstract double average(Object[] students);
+  abstract String largest(Object[] students);
+  abstract String smallest(Object[] students);


[reviewdog] _{reported by reviewdog 🐶}
'METHOD_DEF' should be separated from previous statement.

…into JoshJ-Problems

github-actions · 2020-09-27T20:36:37Z

src/com/codefortomorrow/advanced/chapter15/practice/MeasurableProblem.java

+    }
+}
+
+interface Measurable {


[reviewdog] _{reported by reviewdog 🐶}
Top-level class Measurable has to reside in its own source file.

github-actions · 2020-09-27T20:36:37Z

src/com/codefortomorrow/advanced/chapter15/practice/MeasurableProblem.java

+    //add interface code here
+}
+
+class Student implements Measurable {


[reviewdog] _{reported by reviewdog 🐶}
Top-level class Student has to reside in its own source file.

github-actions · 2020-09-27T20:36:37Z

src/com/codefortomorrow/advanced/chapter15/solutions/MeasurableProblem.java

+    }
+}
+
+interface Measurable {


[reviewdog] _{reported by reviewdog 🐶}
Top-level class Measurable has to reside in its own source file.

github-actions · 2020-09-27T20:36:38Z

src/com/codefortomorrow/advanced/chapter15/solutions/MeasurableProblem.java

+    abstract String smallest(Object[] students);
+}
+
+class Student implements Measurable {


[reviewdog] _{reported by reviewdog 🐶}
Top-level class Student has to reside in its own source file.

github-actions · 2020-09-27T20:36:38Z

src/com/codefortomorrow/advanced/chapter15/solutions/MeasurableProblem.java

+}
+
+class Student implements Measurable {
+    private double GPA;


[reviewdog] _{reported by reviewdog 🐶}
Abbreviation in name 'GPA' must contain no more than '1' consecutive capital letters.

github-actions · 2020-09-27T20:36:40Z

src/com/codefortomorrow/advanced/chapter14/solutions/Lexico.java

+              line2 = br2.readLine();
+              c = line1.compareTo(line2);
+            }
+            if(c > 0)


[reviewdog] _{reported by reviewdog 🐶}
WhitespaceAround: 'if' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)

github-actions · 2020-09-27T20:36:41Z

src/com/codefortomorrow/advanced/chapter14/solutions/Lexico.java

+            }
+            if(c > 0)
+              System.out.println("File 2");
+            else


[reviewdog] _{reported by reviewdog 🐶}
'else' construct must use '{}'s.

github-actions · 2020-09-27T20:36:41Z

src/com/codefortomorrow/advanced/chapter14/solutions/Lexico.java

+              System.out.println("File 2");
+            else
+              System.out.println("File 1");
+        } catch(IOException e){


[reviewdog] _{reported by reviewdog 🐶}
WhitespaceAround: 'catch' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)

github-actions · 2020-09-27T20:36:41Z

src/com/codefortomorrow/advanced/chapter14/solutions/Lexico.java

+              System.out.println("File 2");
+            else
+              System.out.println("File 1");
+        } catch(IOException e){


[reviewdog] _{reported by reviewdog 🐶}
WhitespaceAround: '{' is not preceded with whitespace.

github-actions · 2020-09-27T20:36:41Z

src/com/codefortomorrow/advanced/chapter14/solutions/Lexico.java

+            else
+              System.out.println("File 1");
+        } catch(IOException e){
+          e.printStackTrace();


[reviewdog] _{reported by reviewdog 🐶}
'catch' child has incorrect indentation level 10, expected level should be 12.

ARajan1084

nice work. looks great.

AlveeraMunshi

Looks good!

github-actions · 2020-09-28T04:10:31Z

src/com/codefortomorrow/advanced/chapter14/solutions/Lexico.java

+                line2 = br2.readLine();
+                c = line1.compareTo(line2);
+            }
+            if (c > 0) System.out.println("File 2"); else System.out.println(


[reviewdog] _{reported by reviewdog 🐶}
'if' construct must use '{}'s.

github-actions · 2020-09-28T04:10:31Z

src/com/codefortomorrow/advanced/chapter14/solutions/Lexico.java

+                line2 = br2.readLine();
+                c = line1.compareTo(line2);
+            }
+            if (c > 0) System.out.println("File 2"); else System.out.println(


[reviewdog] _{reported by reviewdog 🐶}
'else' construct must use '{}'s.

github-actions · 2020-09-28T04:10:32Z

src/com/codefortomorrow/advanced/chapter14/solutions/Lexico.java

+            }
+            if (c > 0) System.out.println("File 2"); else System.out.println(
+                "File 1"
+            );


[reviewdog] _{reported by reviewdog 🐶}
Only one statement per line allowed.

JJ27 added 3 commits September 27, 2020 12:44

Add Lexico Problem

264b213

Remove extra class file

1a4f236

Measurable Problem

1df26ee

JJ27 requested review from ARajan1084, AlveeraMunshi and neha-peddinti September 27, 2020 20:29

Bot: Prettified Java code!

7e8c2fe

github-actions bot reviewed Sep 27, 2020

View reviewed changes

JJ27 and others added 4 commits September 27, 2020 16:31

Close Readers

2d5ec4d

Merge branch 'JoshJ-Problems' of https://github.com/code4tomorrow/java …

d57dbb2

…into JoshJ-Problems

Add Try With Resources

e4125f6

Bot: Prettified Java code!

4b404bd

github-actions bot reviewed Sep 27, 2020

View reviewed changes

ARajan1084 approved these changes Sep 27, 2020

View reviewed changes

AlveeraMunshi approved these changes Sep 27, 2020

View reviewed changes

Merge branch 'master' into JoshJ-Problems

47f695e

github-actions bot reviewed Sep 28, 2020

View reviewed changes

ARajan1084 merged commit 4cea04f into master Sep 28, 2020

ARajan1084 deleted the JoshJ-Problems branch September 28, 2020 04:22

		@@ -0,0 +1,24 @@
		package com.codefortomorrow.advanced.chapter15.practice;
		/*

Uh oh!

Ch. 14 and 15 Problems #16

Ch. 14 and 15 Problems #16

Uh oh!

Conversation

JJ27 commented Sep 27, 2020

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 27, 2020

Choose a reason for hiding this comment

Uh oh!

ARajan1084 left a comment

Choose a reason for hiding this comment

Uh oh!

AlveeraMunshi left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 28, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions bot Sep 28, 2020