Advised indexes and statistics

Author: davecharron

package.json

@@ -184,7 +184,7 @@
         {
           "type": "tree",
           "id": "vscode-db2i.dove.node",
-          "name": "Node Detail",
+          "name": "Visual Explain Details",
           "when": "vscode-db2i:explainingNode == true"
         }
       ],
@@ -460,16 +460,28 @@
       },
       {
         "command": "vscode-db2i.dove.close",
-        "title": "Close detail",
+        "title": "Close",
         "category": "Db2 for i",
-        "icon": "$(close-all)"
+        "icon": "$(close)"
       },
       {
-        "command": "vscode-db2i.dove.nodeDetail",
-        "title": "See detail",
+        "command": "vscode-db2i.dove.displayDetails",
+        "title": "Display details",
         "category": "Db2 for i",
         "icon": "$(info)"
       },
+      {
+        "command": "vscode-db2i.dove.closeDetails",
+        "title": "Close",
+        "category": "Db2 for i",
+        "icon": "$(close)"
+      },
+      {
+        "command": "vscode-db2i.dove.advisedIndexesAndStatistics",
+        "title": "Advised Indexes and Statistics",
+        "category": "Db2 for i",
+        "icon": "$(lightbulb)"
+      },
       {
         "command": "vscode-db2i.dove.editSettings",
         "title": "Settings",
@@ -545,9 +557,13 @@
           "when": "never"
         },
         {
-          "command": "vscode-db2i.dove.nodeDetail",
+          "command": "vscode-db2i.dove.displayDetails",
           "when": "never"
         },
+        {
+          "command": "vscode-db2i.dove.advisedIndexesAndStatistics",
+          "when": "vscode-db2i:explaining == true"
+        },
         {
           "command": "vscode-db2i.dove.editSettings",
           "when": "vscode-db2i:explaining == true"
@@ -629,20 +645,30 @@
           "group": "navigation",
           "when": "view == jobManager"
         },
+        {
+          "command": "vscode-db2i.dove.advisedIndexesAndStatistics",
+          "group": "navigation@0",
+          "when": "view == vscode-db2i.dove.nodes"
+        },
         {
           "command": "vscode-db2i.dove.editSettings",
-          "group": "navigation",
+          "group": "navigation@1",
           "when": "view == vscode-db2i.dove.nodes"
         },
         {
           "command": "vscode-db2i.dove.export",
-          "group": "navigation",
+          "group": "navigation@2",
           "when": "view == vscode-db2i.dove.nodes"
         },
         {
           "command": "vscode-db2i.dove.close",
-          "group": "navigation",
+          "group": "navigation@3",
           "when": "view == vscode-db2i.dove.nodes"
+        },
+        {
+          "command": "vscode-db2i.dove.closeDetails",
+          "group": "navigation@1",
+          "when": "view == vscode-db2i.dove.node"
         }
       ],
       "view/item/context": [
@@ -772,7 +798,7 @@
           "group": "inline"
         },
         {
-          "command": "vscode-db2i.dove.nodeDetail",
+          "command": "vscode-db2i.dove.displayDetails",
           "when": "view == vscode-db2i.dove.nodes && viewItem == explainTreeItem",
           "group": "inline"
         }

src/views/results/explain/doveNodeView.ts

@@ -14,15 +14,18 @@ export class DoveNodeView implements TreeDataProvider<any> {
 
   private treeView: TreeView<PropertyNode>;
 
+  private defaultTitle: string;
   constructor() {
     this.treeView = vscode.window.createTreeView(`vscode-db2i.dove.node`, { treeDataProvider: this, showCollapseAll: true });
+    this.defaultTitle = this.treeView.title;
   }
 
   public getTreeView(): TreeView<PropertyNode> {
     return this.treeView;
   }
 
-  setNode(currentNode: ExplainNode) {
+  setNode(currentNode: ExplainNode, title?: string) {
+    this.treeView.title = title || this.defaultTitle;
     this.propertyNodes = [];
     let currentSection: PropertySection = null;
     for (let property of currentNode.props) {

src/views/results/explain/doveResultsView.ts

@@ -69,7 +69,6 @@ export class DoveResultsView implements TreeDataProvider<any> {
     return this.treeView;
   }
 
-
   setRootNode(topNode: ExplainNode): ExplainTreeItem {
     this.topNode = new ExplainTreeItem(topNode);
     this._onDidChangeTreeData.fire();
@@ -80,12 +79,15 @@ export class DoveResultsView implements TreeDataProvider<any> {
     this.treeView.reveal(this.topNode,  { select: false });
     return this.topNode;
   }
+  getRootNode(): ExplainTreeItem {
+    return this.topNode;
+  }
 
-  getRootExplainNode() {
+  getRootExplainNode(): ExplainNode {
     return this.topNode.explainNode;
   }
 
-  close() {
+  close(): void {
     commands.executeCommand(`setContext`, `vscode-db2i:explaining`, false);
   }
 
@@ -106,18 +108,18 @@ export class DoveResultsView implements TreeDataProvider<any> {
   getParent?(element: any) {
     throw new Error("Method not implemented.");
   }
+
   resolveTreeItem?(item: TreeItem, element: any, token: CancellationToken): ProviderResult<ExplainTreeItem> {
     throw new Error("Method not implemented.");
   }
 }
 
 export class ExplainTreeItem extends TreeItem {
-  children: ExplainTreeItem[];
   explainNode: ExplainNode;
+  private children: ExplainTreeItem[];
 
   constructor(node: ExplainNode) {
     super(node.title, node.childrenNodes > 0 ? TreeItemCollapsibleState.Expanded : TreeItemCollapsibleState.None);
-
     this.explainNode = node;
     this.contextValue = `explainTreeItem`;
 
@@ -132,8 +134,10 @@ export class ExplainTreeItem extends TreeItem {
     this.iconPath = new ThemeIcon(icons[node.title] || `server-process`, node.highlights.getPriorityColor()); // `circle-outline`
   }
 
-  getChildren() {
-    return this.explainNode.children.map(c => new ExplainTreeItem(c));
+  getChildren(): ExplainTreeItem[] {
+    if (!this.children) {
+      this.children = this.explainNode.children.map(c => new ExplainTreeItem(c));
+    }
+    return this.children;
   }
-}
-
+}