Improved pull request "Files Changed" experience feedback #163932
Replies: 989 comments 345 replies
-
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state
Example of desired state
This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
The tab for |
Beta Was this translation helpful? Give feedback.
-
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Due to the performance improvements making it pretty fast to render large diffs, it would be nice if there were an option to always render large diffs by default, or at least to keep the ones you expanded on a previous view open the next time you visit the page. Especially if they have comments on them (c.f. https://github.com/orgs/community/discussions/65214). Or, at least bump up how many lines a diff has to be before github considers it "large" and collapses it by default. |
Beta Was this translation helpful? Give feedback.
-
After the first comment on a file, submitting later comments always moved the browser focus back to the first comment on that document. this is especially jarring on large files. |
Beta Was this translation helpful? Give feedback.
-
I've recently tried out the improved "Files Changed" experience in pull requests, and I must say it's a solid upgrade! Here’s my feedback: Performance: The new interface feels faster, especially when reviewing large PRs with multiple files. This really helps reduce friction during code reviews. Filtering & Navigation: The ability to filter changes by file type or directory is a game-changer. It saves a lot of time when working on monorepos or larger codebases. Side-by-Side View: The refined side-by-side diff is cleaner and more readable. The syntax highlighting is sharper and makes reviewing much easier. Sticky Headers: Love the sticky file headers while scrolling through long diffs. This small UX improvement goes a long way. 💡 Suggestions: It would be great to have collapsible sections per file to reduce scrolling when we already reviewed certain files. Maybe introduce inline commenting shortcuts to speed up feedback further. Overall, I appreciate GitHub continuing to improve the PR review experience—it really impacts productivity and collaboration in open-source and team workflows alike! |
Beta Was this translation helpful? Give feedback.
-
Still no SVG diff support... sadge |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Clicking I'm on Firefox 136.0 on Ubuntu using Tridactyl 1.24.2. |
Beta Was this translation helpful? Give feedback.
-
A file was deleted after review, which broke the reviewed file progress. ![]() |
Beta Was this translation helpful? Give feedback.
-
I am fairly certain I used to be able to finish reviewing a PR without having to leave a parent comment; now it forces me to do that which I do not want to do if possible :D |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
A lot of people don’t realize that car key fobs actually hold some surprising value, especially when they’re in working condition. Whether you're upgrading your vehicle or just clearing out a drawer, it’s worth taking a moment to find out how much are key fobs worth before tossing them out. You might be sitting on a little extra cash without even knowing it. |
Beta Was this translation helpful? Give feedback.
-
I'm disappointed that it still doesn't work to:
All these features are already available in GitHub Visual Studio Code plugin or Azure DevOps. |
Beta Was this translation helpful? Give feedback.
-
In many discussions about emergency preparedness, people highlight how vital it is to have devices that are easy to use under stress. These products are appreciated because they provide clear voice prompts and reliable performance when every second counts. They are often placed in schools, offices, airports, and community spaces to make sure help is always close by. Conversations frequently mention how choosing a trusted brand gives users more confidence in critical moments. A commonly recommended option in such talks is the philips aed |
Beta Was this translation helpful? Give feedback.
-
Animated gif at the end of the file-diff is distracted, it should be removed. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests.
What’s new ?
Performance 🚀
UX ✨
Accessibility
What's missing? 🟨
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions