From b6cafd4c0c309b31c60c451a9a817a933399906e Mon Sep 17 00:00:00 2001
From: Justin Wang <35274216+Claimundefine@users.noreply.github.com>
Date: Mon, 30 Sep 2024 15:05:24 -0400
Subject: [PATCH] Schemaregistry examples (#69)

* Add restService interfaces to exported types

* Bugfix for rest service and oauth
---
 schemaregistry/package.json    |  2 +-
 schemaregistry/rest-service.ts | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/schemaregistry/package.json b/schemaregistry/package.json
index 07909e84..fc47ccc4 100644
--- a/schemaregistry/package.json
+++ b/schemaregistry/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@confluentinc/schemaregistry",
-  "version": "v0.1.17.4-devel",
+  "version": "v0.1.17.6-devel",
   "description": "Node.js client for Confluent Schema Registry",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
diff --git a/schemaregistry/rest-service.ts b/schemaregistry/rest-service.ts
index c7e2b693..537ec7f4 100644
--- a/schemaregistry/rest-service.ts
+++ b/schemaregistry/rest-service.ts
@@ -101,10 +101,10 @@ export class RestService {
       delete this.client.defaults.auth;
 
       const headers = ['logicalCluster', 'identityPoolId'];
-      const missingHeaders = headers.find(header => bearerAuthCredentials[header as keyof typeof bearerAuthCredentials]);
+      const missingHeader = headers.find(header => !(header in bearerAuthCredentials));
 
-      if (missingHeaders) {
-        throw new Error(`Bearer auth header '${missingHeaders}' not provided`);
+      if (missingHeader) {
+        throw new Error(`Bearer auth header '${missingHeader}' not provided`);
       }
 
       this.setHeaders({
@@ -127,14 +127,14 @@ export class RestService {
             'issuerEndpointUrl',
             'scope'
           ];
-          const missingField = requiredFields.find(field => bearerAuthCredentials[field as keyof typeof bearerAuthCredentials]);
+          const missingField = requiredFields.find(field => !(field in bearerAuthCredentials));
 
           if (missingField) {
             throw new Error(`OAuth credential '${missingField}' not provided`);
           }
           const issuerEndPointUrl = new URL(bearerAuthCredentials.issuerEndpointUrl!);
           this.oauthClient = new OAuthClient(bearerAuthCredentials.clientId!, bearerAuthCredentials.clientSecret!,
-            issuerEndPointUrl.host, issuerEndPointUrl.pathname, bearerAuthCredentials.scope!);
+            issuerEndPointUrl.origin, issuerEndPointUrl.pathname, bearerAuthCredentials.scope!);
           break;
         default:
           throw new Error('Invalid bearer auth credentials source');