Skip to content

PRW2 accepts invalid histograms instead of rejecting them #7042

@roidelapluie

Description

@roidelapluie

Describe the bug
When a native histogram with a wrong code is received, it is ingested by cortex rather than being rejected (like Prometheus does)

To Reproduce
Steps to reproduce the behavior:

  1. Start Cortex 0e9721f
  2. Remote write an histogram with bad count (Add remote write 2 receivers compliance tests prometheus/compliance#182)

Expected behavior

Prometheus returns 400:

23 observations found in buckets, but the Count field is 99: histogram's observation count should equal the number of observations found in the buckets (in absence of NaN) for series {name="minimal_hist"}

Cortex returns 200.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions