eth, les: unlock downloader peerSet if there's an error (ethereum#25546)

jtraglia · cp-wjhan · commit 17188a025302 · 2023-10-23T10:37:58.000+09:00
Unlock peerSet if there's an error in the downloader
diff --git a/eth/downloader/peer.go b/eth/downloader/peer.go
@@ -237,6 +237,7 @@ func (ps *peerSet) Register(p *peerConnection) error {
 	}
 	p.rates = msgrate.NewTracker(ps.rates.MeanCapacities(), ps.rates.MedianRoundTrip())
 	if err := ps.rates.Track(p.id, p.rates); err != nil {
+		ps.lock.Unlock()
 		return err
 	}
 	ps.peers[p.id] = p
diff --git a/les/downloader/peer.go b/les/downloader/peer.go
@@ -350,6 +350,7 @@ func (ps *peerSet) Register(p *peerConnection) error {
 	}
 	p.rates = msgrate.NewTracker(ps.rates.MeanCapacities(), ps.rates.MedianRoundTrip())
 	if err := ps.rates.Track(p.id, p.rates); err != nil {
+		ps.lock.Unlock()
 		return err
 	}
 	ps.peers[p.id] = p

Original file line number	Diff line number	Diff line change
`@@ -237,6 +237,7 @@ func (ps peerSet) Register(p peerConnection) error {`
`237`	`237`	`}`
`238`	`238`	`p.rates = msgrate.NewTracker(ps.rates.MeanCapacities(), ps.rates.MedianRoundTrip())`
`239`	`239`	`if err := ps.rates.Track(p.id, p.rates); err != nil {`
	`240`	`+ ps.lock.Unlock()`
`240`	`241`	`return err`
`241`	`242`	`}`
`242`	`243`	`ps.peers[p.id] = p`
Original file line number	Diff line number	Diff line change
`@@ -350,6 +350,7 @@ func (ps peerSet) Register(p peerConnection) error {`
`350`	`350`	`}`
`351`	`351`	`p.rates = msgrate.NewTracker(ps.rates.MeanCapacities(), ps.rates.MedianRoundTrip())`
`352`	`352`	`if err := ps.rates.Track(p.id, p.rates); err != nil {`
	`353`	`+ ps.lock.Unlock()`
`353`	`354`	`return err`
`354`	`355`	`}`
`355`	`356`	`ps.peers[p.id] = p`