Remove unused extension method, replaced in analyzer 8.4.0 (#4119)

With analyzer 8.4.0, `Element` now has a proper instance method,
`isDeprecatedWithKind`, which usurps our extension method. 🎉

Author: srawlins

lib/src/model/model_element.dart

@@ -831,16 +831,6 @@ extension on Element {
   }
 }
 
-// Copied from analyzer's `lib/src/dart/element/extensions.dart`. Re-use that
-// extension if it becomes public.
-extension on Element {
-  /// Whether this Element is annotated with a `Deprecated` annotation with a
-  /// `_DeprecationKind` of [kind].
-  bool isDeprecatedWithKind(String kind) => metadata.annotations
-      .where((e) => e.isDeprecated)
-      .any((e) => e.deprecationKind == kind);
-}
-
 // Copied from analyzer's `lib/src/dart/element/extensions.dart`. Re-use that
 // extension if it becomes public.
 extension ElementAnnotationExtension on ElementAnnotation {

pubspec.yaml

@@ -7,7 +7,7 @@ environment:
   sdk: ^3.6.0
 
 dependencies:
-  analyzer: ^8.2.0
+  analyzer: ^8.4.0
   args: ^2.4.1
   collection: ^1.17.0
   crypto: ^3.0.3