feat: take filenames as input args for script

Update readme with changes

Author: thephez

scripts/core-rpc-tools/README.md

@@ -80,9 +80,10 @@ This generates:
 Compare the two versions and generate a detailed change report:
 
 ```bash
-# Edit generate-rpc-change-summary.py to set your file paths
-
-python3 generate-rpc-change-summary.py
+# Pass the two JSONL files as command-line arguments
+python3 generate-rpc-change-summary.py \
+  dash-cli-help-22.1.3-<timestamp>.jsonl \
+  dash-cli-help-23.0.0-<timestamp>.jsonl
 ```
 
 This generates:
@@ -141,21 +142,19 @@ NET_ARGS="" ./dump-cli-help.sh  # mainnet
 **Usage**:
 
 ```bash
-# Edit the script to set your input files
-nano generate-rpc-change-summary.py
-
-# Then run
-python3 generate-rpc-change-summary.py
+python3 generate-rpc-change-summary.py <old_version.jsonl> <new_version.jsonl>
 ```
 
-**Configuration** (edit the `__main__` block at the bottom):
+**Examples**:
 
-```python
-if __name__ == '__main__':
-    old_file = 'dash-cli-help-<old_version>-<timestamp>.jsonl'
-    new_file = 'dash-cli-help-<new_version>-<timestamp>.jsonl'
+```bash
+# Compare version 22.1.3 to 23.0.0
+python3 generate-rpc-change-summary.py \
+  dash-cli-help-22.1.3-20251104T214929Z.jsonl \
+  dash-cli-help-23.0.0-20251104T213450Z.jsonl
 
-    # ... rest of script
+# The script automatically extracts version info from the JSONL metadata
+# and creates an appropriately named output file
 ```
 
 ## Output Files Reference

scripts/core-rpc-tools/dump-cli-help.sh

@@ -1,18 +1,18 @@
 #!/usr/bin/env bash
 #
-# dump-dash-cli-help.sh
+# dump-cli-help.sh
 #
 # Iterate over all dash-cli RPC commands (including subcommands where applicable)
 # and dump their help text into:
 #   - A single readable text file (OUT)
 #   - Optionally, a newline-delimited JSON file (OUT_JSONL) for machine parsing
 #
 # Usage:
-#   chmod +x dump-dash-cli-help.sh
-#   ./dump-dash-cli-help.sh
+#   chmod +x dump-cli-help.sh
+#   ./dump-cli-help.sh
 #
 # Overrides:
-#   CLI=/path/to/dash-cli NET_ARGS="-testnet" OUT="help.txt" ./dump-dash-cli-help.sh
+#   CLI=/path/to/dash-cli NET_ARGS="-testnet" OUT="help.txt" ./dump-cli-help.sh
 #
 # Dependencies:
 #   Needs a running Dash node with RPC access (same as using dash-cli manually).

scripts/core-rpc-tools/generate-rpc-change-summary.py

@@ -3,9 +3,9 @@
 Generate executive summary of RPC changes between versions.
 """
 
+import argparse
 import json
 import re
-import os
 from collections import defaultdict
 
 # ---------- JSONL parsing & metadata ----------
@@ -472,11 +472,14 @@ def generate_summary(old_file, new_file, old_version=None, new_version=None):
 # ---------- CLI ----------
 
 if __name__ == '__main__':
-    # Sample usage — update paths as needed
-    old_file = 'dash-cli-help-22.1.3-20251104T214929Z.jsonl'
-    new_file = 'dash-cli-help-23.0.0-rc.3-20251104T213450Z.jsonl'
-
-    report, old_ver, new_ver = generate_summary(old_file, new_file)
+    parser = argparse.ArgumentParser(
+        description="Generate executive summary of Dash Core RPC changes between two JSONL dumps."
+    )
+    parser.add_argument("old_jsonl", help="Path to OLD version JSONL file")
+    parser.add_argument("new_jsonl", help="Path to NEW version JSONL file")
+    args = parser.parse_args()
+
+    report, old_ver, new_ver = generate_summary(args.old_jsonl, args.new_jsonl)
 
     # Build output filename from metadata versions if available
     safe_old = re.sub(r'[^A-Za-z0-9._-]+', '_', old_ver)