Skip to content

Conversation

@sundy-li
Copy link
Member

@sundy-li sundy-li commented Aug 3, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Disable overflow-checks which may break ci tests.

SQL: SELECT AVG(UserID) FROM hits;
origin_img_v2_1ae12281-7a9f-421d-a70d-cb023939970g

Fixes #issue

@vercel
Copy link

vercel bot commented Aug 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Sep 3, 2022 at 2:14AM (UTC)

@sundy-li sundy-li requested a review from PsiACE August 3, 2022 02:14
@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Aug 3, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Aug 3, 2022

Disable overflow-checks which may break ci tests.

Seems dangerous to me. This change could also ignore the overflow that we don't expect.

Can we use overflowing_add or saturating_add in the logic that we expect to have overflowing?

@sundy-li sundy-li closed this Aug 3, 2022
@sundy-li
Copy link
Member Author

sundy-li commented Aug 3, 2022

Disable overflow-checks which may break ci tests.

Seems dangerous to me. This change could also ignore the overflow that we don't expect.

Can we use overflowing_add or saturating_add in the logic that we expect to have overflowing?

That's right!

@Xuanwo Xuanwo deleted the sundy-li-patch-1 branch August 3, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants