Skip to content

Conversation

@Kaiqgs
Copy link
Collaborator

@Kaiqgs Kaiqgs commented Oct 25, 2025

Test evidence

test_pthread_evidence.mp4

@Kaiqgs Kaiqgs linked an issue Oct 25, 2025 that may be closed by this pull request
@Kaiqgs Kaiqgs self-assigned this Oct 26, 2025

wasm_pthread-web:
context:
libs: ["fmodbridge", "fmodstudio"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a sneak-pick: the common fields can be defined under web section

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekharkunov does this common web section take precedence? What is the order of definition?

Could I make it like

web:
  context:
    libs: ["fmodbridge", "fmodstudio"]

wasm_pthread-web:
  context:
    emscriptenLinkFlags: ["EXPORTED_RUNTIME_METHODS=[\"ccall\",\"callMain\",\"UTF8ToString\",\"HEAPU8\",\"stringToUTF8\",\"cwrap\",\"getValue\",\"setValue\"]", "-pthread", "-s PTHREAD_POOL_SIZE=5"]

would this work for pthread specific declaration?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order is common<-web<-wasm_pthread-web. So yes, It should work like this. Otherwise we have a bug on Extender's side

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, that you need emscriptenLinkFlags: ["EXPORTED_RUNTIME_METHODS=[\"ccall\",\"callMain\",\"UTF8ToString\",\"HEAPU8\",\"stringToUTF8\",\"cwrap\",\"getValue\",\"setValue\"]"] for web section

@Kaiqgs Kaiqgs requested a review from britzl October 27, 2025 23:35
@Kaiqgs
Copy link
Collaborator Author

Kaiqgs commented Oct 28, 2025

Somehow, the bundle was getting stuck in an infinite loop. I could only change the makefile and maintain a working bundle.

pthread_pool_not_5_fail.mp4

Copy link

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments from Evgeniy

@Kaiqgs Kaiqgs requested a review from britzl October 29, 2025 14:36
@Kaiqgs
Copy link
Collaborator Author

Kaiqgs commented Oct 29, 2025

See comments from Evgeniy

@britzl I have updated the manifest with a better declaration. Can you review?

@Kaiqgs Kaiqgs merged commit 61a65f5 into update-fmod-20309 Nov 1, 2025
@Kaiqgs Kaiqgs deleted the 17-fmod-20309-pthread-support branch November 1, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FMOD 2.03.09 Wasm Pthread Support

4 participants