-
Notifications
You must be signed in to change notification settings - Fork 0
17 - Fmod 2.03.09 pthread Support #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fmod/ext.manifest
Outdated
|
|
||
| wasm_pthread-web: | ||
| context: | ||
| libs: ["fmodbridge", "fmodstudio"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a sneak-pick: the common fields can be defined under web section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekharkunov does this common web section take precedence? What is the order of definition?
Could I make it like
web:
context:
libs: ["fmodbridge", "fmodstudio"]
wasm_pthread-web:
context:
emscriptenLinkFlags: ["EXPORTED_RUNTIME_METHODS=[\"ccall\",\"callMain\",\"UTF8ToString\",\"HEAPU8\",\"stringToUTF8\",\"cwrap\",\"getValue\",\"setValue\"]", "-pthread", "-s PTHREAD_POOL_SIZE=5"]
would this work for pthread specific declaration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order is common<-web<-wasm_pthread-web. So yes, It should work like this. Otherwise we have a bug on Extender's side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, that you need emscriptenLinkFlags: ["EXPORTED_RUNTIME_METHODS=[\"ccall\",\"callMain\",\"UTF8ToString\",\"HEAPU8\",\"stringToUTF8\",\"cwrap\",\"getValue\",\"setValue\"]"] for web section
|
Somehow, the bundle was getting stuck in an infinite loop. I could only change the makefile and maintain a working bundle. pthread_pool_not_5_fail.mp4 |
britzl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments from Evgeniy
@britzl I have updated the manifest with a better declaration. Can you review? |
Test evidence
test_pthread_evidence.mp4