Add CategoryPublisher application #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes diffplug#124 Add a class that wraps the CategoryPublisher application. Add a test class that tests a basic scenario involving the FeaturesAndBundlesPublisher and the CategoryPublisher. Testing the CategoryPublisher without the FeaturesAndBundlesPublisher would require to create eclipse metadata manually. Therefore, both applications are used.
|
Looks great, thanks! If you:
Then I'll merge and release. |
|
Thanks again, published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #124
Add a class that wraps the CategoryPublisher application.
Add a test class that tests a basic scenario involving the FeaturesAndBundlesPublisher
and CategoryPublisher application.
Testing the CategoryPublisher without the FeaturesAndBundlesPublisher would require
to create eclipse metadata manually. Therefore, both applications are used.
Even if the the documentation lists the argument
categoryQualifierwithout an additional URL argument,I implemented it with an URL because of the application's implementation expects an argument.