Skip to content

Commit 8fe7545

Browse files
committed
TODO: can we remove the "JSONMessage" wrapping?
Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent f81d60a commit 8fe7545

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

pkg/api/dryrunclient.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ func (d *DryRunClient) CopyToContainer(ctx context.Context, container, path stri
203203
}
204204

205205
func (d *DryRunClient) ImageBuild(ctx context.Context, reader io.Reader, options client.ImageBuildOptions) (client.ImageBuildResponse, error) {
206+
// TODO(thaJeztah): can we use api/types/jsonstream (or api/pkg/xxxxx) for this?
206207
jsonMessage, err := json.Marshal(&jsonmessage.JSONMessage{
207208
Status: fmt.Sprintf("%[1]sSuccessfully built: dryRunID\n%[1]sSuccessfully tagged: %[2]s\n", DRYRUN_PREFIX, options.Tags[0]),
208209
Progress: &jsonmessage.JSONProgress{},
@@ -250,6 +251,8 @@ func (d *DryRunClient) ImagePush(ctx context.Context, ref string, options client
250251
if _, _, err := d.resolver.Resolve(ctx, ref); err != nil {
251252
return nil, err
252253
}
254+
255+
// TODO(thaJeztah): can we use api/types/jsonstream (or api/pkg/xxxxx) for this?
253256
jsonMessage, err := json.Marshal(&jsonmessage.JSONMessage{
254257
Status: "Pushed",
255258
Progress: &jsonmessage.JSONProgress{

0 commit comments

Comments
 (0)