Escape Param data for the exporters #2135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YegorStepanov
changed the title
adamsitnik
approved these changes
Oct 6, 2022
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @YegorStepanov !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds escaping the
Paramdata for the exporters only.Currently, you can only pass
\t,\n, other control characters throw an exception in the generated project).Try
Param["\0"] string Param(In the linked PR below I fix it).Microsoft.CodeAnalysis.CSharp.SymbolDisplay.FormatLiteral(str, quote);the naming is 10/10 😄. It escapes the non-displayed characters and emojis.
I don't escape the
column.ColumnName, because that would require calling.EscapeSpecialCharacter()after every 'column.ColumName' (~20 times).Fixes #1867
Fixes #1839