Skip to content

Commit 8b0e836

Browse files
Fix bug with LegacyRowVersionNullBehavior
1 parent 7f0e3bb commit 8b0e836

File tree

2 files changed

+23
-23
lines changed

2 files changed

+23
-23
lines changed

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDataReader.cs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,7 @@ protected override void Dispose(bool disposing)
842842
}
843843
base.Dispose(disposing);
844844
}
845-
catch(SqlException ex)
845+
catch (SqlException ex)
846846
{
847847
SqlClientEventSource.Log.TryTraceEvent("SqlDataReader.Dispose | ERR | Error Message: {0}, Stack Trace: {1}", ex.Message, ex.StackTrace);
848848
}
@@ -3775,17 +3775,17 @@ private bool TryReadColumnInternal(int i, bool readHeaderOnly = false)
37753775
{
37763776
_data[i].SetToNullOfType(SqlBuffer.StorageType.SqlBinary);
37773777
}
3778-
}
3779-
else
3780-
{
3781-
TdsParser.GetNullSqlValue(_data[_sharedState._nextColumnDataToRead],
3782-
columnMetaData,
3783-
_command != null ? _command.ColumnEncryptionSetting : SqlCommandColumnEncryptionSetting.UseConnectionSetting,
3784-
_parser.Connection);
3785-
3786-
if (!readHeaderOnly)
3778+
else
37873779
{
3788-
_sharedState._nextColumnDataToRead++;
3780+
TdsParser.GetNullSqlValue(_data[_sharedState._nextColumnDataToRead],
3781+
columnMetaData,
3782+
_command != null ? _command.ColumnEncryptionSetting : SqlCommandColumnEncryptionSetting.UseConnectionSetting,
3783+
_parser.Connection);
3784+
3785+
if (!readHeaderOnly)
3786+
{
3787+
_sharedState._nextColumnDataToRead++;
3788+
}
37893789
}
37903790
}
37913791
}
@@ -5021,7 +5021,7 @@ override public Task<T> GetFieldValueAsync<T>(int i, CancellationToken cancellat
50215021
{
50225022
_stateObj._shouldHaveEnoughData = true;
50235023
#endif
5024-
return Task.FromResult(GetFieldValueInternal<T>(i));
5024+
return Task.FromResult(GetFieldValueInternal<T>(i));
50255025
#if DEBUG
50265026
}
50275027
finally
@@ -5115,7 +5115,7 @@ internal void CompletePendingReadWithFailure(int errorCode, bool resetForcePendi
51155115

51165116
#endif
51175117

5118-
internal abstract class SqlDataReaderAsyncCallContext<T> : AAsyncCallContext<SqlDataReader,T>
5118+
internal abstract class SqlDataReaderAsyncCallContext<T> : AAsyncCallContext<SqlDataReader, T>
51195119
{
51205120
internal static readonly Action<Task<T>, object> s_completeCallback = CompleteAsyncCallCallback;
51215121

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4287,17 +4287,17 @@ private bool TryReadColumnInternal(int i, bool readHeaderOnly = false)
42874287
{
42884288
_data[i].SetToNullOfType(SqlBuffer.StorageType.SqlBinary);
42894289
}
4290-
}
4291-
else
4292-
{
4293-
TdsParser.GetNullSqlValue(_data[_sharedState._nextColumnDataToRead],
4294-
columnMetaData,
4295-
_command != null ? _command.ColumnEncryptionSetting : SqlCommandColumnEncryptionSetting.UseConnectionSetting,
4296-
_parser.Connection);
4297-
4298-
if (!readHeaderOnly)
4290+
else
42994291
{
4300-
_sharedState._nextColumnDataToRead++;
4292+
TdsParser.GetNullSqlValue(_data[_sharedState._nextColumnDataToRead],
4293+
columnMetaData,
4294+
_command != null ? _command.ColumnEncryptionSetting : SqlCommandColumnEncryptionSetting.UseConnectionSetting,
4295+
_parser.Connection);
4296+
4297+
if (!readHeaderOnly)
4298+
{
4299+
_sharedState._nextColumnDataToRead++;
4300+
}
43014301
}
43024302
}
43034303
}

0 commit comments

Comments
 (0)