-
Notifications
You must be signed in to change notification settings - Fork 317
[6.1] Add new trusted AKV URLs for FR and DE #3486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added 4 new trusted AKV URLs. - Fixed existing manual tests and added unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Port the addition of new Azure Key Vault trusted endpoints and update related tests for the 6.1 release branch.
- Add four new trusted AKV URLs (France & Germany) to the domain list.
- Update exception helper to return
ArgumentExceptionand centralize error message generation. - Register the new
TrustedUrlsTestin the manual tests project and refactor existing tests to use the helper.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj | Re-add compile entries for new/updated AlwaysEncrypted tests. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TrustedUrlsTest.cs | Introduce a test for valid/invalid vault URLs and helper. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ExceptionTestAKVStore.cs | Replace hard-coded expected message with the new helper call. |
| src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Utils.cs | Change exception factory to return ArgumentException. |
| src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Constants.cs | Expand AKV domain list with new regions using C# 12 syntax. |
Comments suppressed due to low confidence (1)
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Utils.cs:144
- [nitpick] The method name
InvalidAKVUrlTrustedEndpointsdoesn’t match the resource keyInvalidAkvKeyPathTrustedTemplate. Consider renaming it toInvalidAKVKeyPathTrustedEndpointsfor consistency and clearer intent.
internal static ArgumentException InvalidAKVUrlTrustedEndpoints(string masterKeyPath, string endpoints) =>
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TrustedUrlsTest.cs
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3486 +/- ##
===============================================
+ Coverage 66.09% 66.91% +0.82%
===============================================
Files 281 281
Lines 62408 62416 +8
===============================================
+ Hits 41247 41768 +521
+ Misses 21161 20648 -513
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 1ccdf40.
Port of #3482 from main to release/6.1