Skip to content

Conversation

@paulmedynski
Copy link
Contributor

Port of #3482 from main to release/6.1

  • Added 4 new trusted AKV URLs.
  • Fixed existing manual tests and added unit tests.
  • Removed unnecessary strings and console output from TrustedUrlsTest.

- Added 4 new trusted AKV URLs.
- Fixed existing manual tests and added unit tests.
@paulmedynski paulmedynski added this to the 6.1.0 milestone Jul 17, 2025
Copilot AI review requested due to automatic review settings July 17, 2025 11:43
@paulmedynski paulmedynski requested a review from a team as a code owner July 17, 2025 11:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Port the addition of new Azure Key Vault trusted endpoints and update related tests for the 6.1 release branch.

  • Add four new trusted AKV URLs (France & Germany) to the domain list.
  • Update exception helper to return ArgumentException and centralize error message generation.
  • Register the new TrustedUrlsTest in the manual tests project and refactor existing tests to use the helper.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj Re-add compile entries for new/updated AlwaysEncrypted tests.
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TrustedUrlsTest.cs Introduce a test for valid/invalid vault URLs and helper.
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ExceptionTestAKVStore.cs Replace hard-coded expected message with the new helper call.
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Utils.cs Change exception factory to return ArgumentException.
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Constants.cs Expand AKV domain list with new regions using C# 12 syntax.
Comments suppressed due to low confidence (1)

src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Utils.cs:144

  • [nitpick] The method name InvalidAKVUrlTrustedEndpoints doesn’t match the resource key InvalidAkvKeyPathTrustedTemplate. Consider renaming it to InvalidAKVKeyPathTrustedEndpoints for consistency and clearer intent.
        internal static ArgumentException InvalidAKVUrlTrustedEndpoints(string masterKeyPath, string endpoints) =>

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.91%. Comparing base (5daddba) to head (097041c).
Report is 2 commits behind head on release/6.1.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/6.1    #3486      +/-   ##
===============================================
+ Coverage        66.09%   66.91%   +0.82%     
===============================================
  Files              281      281              
  Lines            62408    62416       +8     
===============================================
+ Hits             41247    41768     +521     
+ Misses           21161    20648     -513     
Flag Coverage Δ
addons 91.04% <100.00%> (+0.22%) ⬆️
netcore 68.98% <ø> (+0.02%) ⬆️
netfx 69.25% <ø> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski merged commit 1ccdf40 into release/6.1 Jul 18, 2025
129 checks passed
@paulmedynski paulmedynski deleted the dev/paul/release/6.1-akv-urls branch July 18, 2025 11:27
paulmedynski added a commit that referenced this pull request Jul 23, 2025
@paulmedynski paulmedynski removed this from the 6.1.0 milestone Jul 23, 2025
paulmedynski added a commit that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants