From 2d0244bb61ac40cd10b11739f9f11e5efe6906ed Mon Sep 17 00:00:00 2001 From: Karina Zhou Date: Mon, 10 Aug 2020 15:07:07 -0700 Subject: [PATCH] Remove duplicate CacheConnectionStringProperties calls --- .../netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs | 2 -- .../netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs | 3 --- 2 files changed, 5 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs index a139327841..b82137f669 100644 --- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs +++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs @@ -114,7 +114,6 @@ private static readonly ConcurrentDictionary> _ColumnEncry public SqlConnection(string connectionString) : this() { ConnectionString = connectionString; // setting connection string first so that ConnectionOption is available - CacheConnectionStringProperties(); } /// @@ -157,7 +156,6 @@ public SqlConnection(string connectionString, SqlCredential credential) : this() // else // credential == null: we should not set "Credential" as this will do additional validation check and // checking pool groups which is not necessary. All necessary operation is already done by calling "ConnectionString = connectionString" - CacheConnectionStringProperties(); } private SqlConnection(SqlConnection connection) diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs index a0775464f4..8181a4e27d 100644 --- a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs +++ b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs @@ -336,7 +336,6 @@ public SqlConnection(string connectionString, SqlCredential credential) : this() // else // credential == null: we should not set "Credential" as this will do additional validation check and // checking pool groups which is not necessary. All necessary operation is already done by calling "ConnectionString = connectionString" - CacheConnectionStringProperties(); } private SqlConnection(SqlConnection connection) @@ -3231,5 +3230,3 @@ internal struct MEMMAP internal byte[] rgbData; } } // Microsoft.Data.SqlClient namespace - -