Fix Dll SearchPath to include Assembly Directory. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 28b4639 added the ability to load the 32bit dll from the current directory. However on MacOS/dotnet this does not work. The current `DllImportSearchPath` setting only allows for loading from known `Safe` paths. On MacOS/dotnet it seems this does not include the assembly directoy. Our current setup in Xamarin.Android places the native libaries in the same directory as the assembly, so we need that to work. The fix is to include the value `AssemblyDirectory` in the `DllImportSearchPath` setting as well as the `SafeDirectories` value. This should allow `dotnet` to find native libraries which are in the same directory.
grendello
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 28b4639 added the ability to load the 32bit
dll from the current directory. However on MacOS/dotnet
this does not work. The current
DllImportSearchPathsetting only allows for loading from known
Safepaths.On MacOS/dotnet it seems this does not include the
assembly directoy. Our current setup in Xamarin.Android
places the native libaries in the same directory as
the assembly, so we need that to work.
The fix is to include the value
AssemblyDirectoryin theDllImportSearchPathsetting as well as theSafeDirectoriesvalue. This should allow
dotnetto find native libraries whichare in the same directory.