[Linux] Properly parse single-digit Ubuntu version #5463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#4929 Some releases of Ubuntu use only a single digit for their version, which the `Version` class is not able to parse properly. Add a special case to handle it. Additionally, don't hardcode `Ubuntu` into error message, use the actual (derived) distro name instead.
radekdoulik
approved these changes
Jan 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4929
Some releases of Ubuntu use only a single digit for their version, which
the
Versionclass is not able to parse properly. Add a special caseto handle it.
Additionally, don't hardcode
Ubuntuinto error message, use theactual (derived) distro name instead.