From 9a538eeb6b5ccf26155e768145c6fdad77c3bdef Mon Sep 17 00:00:00 2001 From: Matthew Leibowitz Date: Fri, 30 Aug 2024 00:39:12 +0800 Subject: [PATCH 1/2] Remove the default SupportedOSPlatformVersion value All the other .NET SDKs and workloads don't do anything and the SDK will set it to the TFM version. This default here also makes it hard to know if the user has set the value and we should warn about the value, or if we are allowed to set it. By keeping it blank, any value means the user set it, but blank means we can set it to a better default in the MAUI SDK. --- .../targets/Microsoft.Android.Sdk.DefaultProperties.targets | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets index 54bd98fe3d4..51e5d4f567a 100644 --- a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets +++ b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets @@ -26,11 +26,6 @@ <_GetChildProjectCopyToPublishDirectoryItems>false true - - $(AndroidMinimumSupportedApiLevel) - - $(SupportedOSPlatformVersion).0 - class-parse From 36838eb88dacc627a1f15781b10c39b8e901b2af Mon Sep 17 00:00:00 2001 From: Matthew Leibowitz Date: Fri, 30 Aug 2024 00:54:10 +0800 Subject: [PATCH 2/2] Update Microsoft.Android.Sdk.DefaultProperties.targets --- .../targets/Microsoft.Android.Sdk.DefaultProperties.targets | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets index 51e5d4f567a..7d1571257a6 100644 --- a/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets +++ b/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets @@ -26,6 +26,9 @@ <_GetChildProjectCopyToPublishDirectoryItems>false true + + $(SupportedOSPlatformVersion).0 + class-parse