Skip to content

Commit 34d6aab

Browse files
authored
Don't display telemetry actions when no telemetry (#6568)
1 parent a764cca commit 34d6aab

File tree

1 file changed

+34
-34
lines changed

1 file changed

+34
-34
lines changed

src/Aspire.Dashboard/Components/Controls/ResourceActions.razor.cs

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -81,44 +81,44 @@ protected override void OnParametersSet()
8181

8282
// Show telemetry menu items if there is telemetry for the resource.
8383
var hasTelemetryApplication = TelemetryRepository.GetApplicationByCompositeName(Resource.Name) != null;
84-
var telemetryTooltip = !hasTelemetryApplication ? Loc[nameof(Resources.Resources.ResourceActionTelemetryTooltip)] : string.Empty;
85-
_menuItems.Add(new MenuButtonItem { IsDivider = true });
86-
_menuItems.Add(new MenuButtonItem
84+
if (hasTelemetryApplication)
8785
{
88-
Text = Loc[nameof(Resources.Resources.ResourceActionStructuredLogsText)],
89-
Icon = s_structuredLogsIcon,
90-
OnClick = () =>
86+
var telemetryTooltip = !hasTelemetryApplication ? Loc[nameof(Resources.Resources.ResourceActionTelemetryTooltip)] : string.Empty;
87+
_menuItems.Add(new MenuButtonItem { IsDivider = true });
88+
_menuItems.Add(new MenuButtonItem
9189
{
92-
NavigationManager.NavigateTo(DashboardUrls.StructuredLogsUrl(resource: GetResourceName(Resource)));
93-
return Task.CompletedTask;
94-
},
95-
Tooltip = telemetryTooltip,
96-
IsDisabled = !hasTelemetryApplication
97-
});
98-
_menuItems.Add(new MenuButtonItem
99-
{
100-
Text = Loc[nameof(Resources.Resources.ResourceActionTracesText)],
101-
Icon = s_tracesIcon,
102-
OnClick = () =>
90+
Text = Loc[nameof(Resources.Resources.ResourceActionStructuredLogsText)],
91+
Icon = s_structuredLogsIcon,
92+
OnClick = () =>
93+
{
94+
NavigationManager.NavigateTo(DashboardUrls.StructuredLogsUrl(resource: GetResourceName(Resource)));
95+
return Task.CompletedTask;
96+
},
97+
Tooltip = telemetryTooltip
98+
});
99+
_menuItems.Add(new MenuButtonItem
103100
{
104-
NavigationManager.NavigateTo(DashboardUrls.TracesUrl(resource: GetResourceName(Resource)));
105-
return Task.CompletedTask;
106-
},
107-
Tooltip = telemetryTooltip,
108-
IsDisabled = !hasTelemetryApplication
109-
});
110-
_menuItems.Add(new MenuButtonItem
111-
{
112-
Text = Loc[nameof(Resources.Resources.ResourceActionMetricsText)],
113-
Icon = s_metricsIcon,
114-
OnClick = () =>
101+
Text = Loc[nameof(Resources.Resources.ResourceActionTracesText)],
102+
Icon = s_tracesIcon,
103+
OnClick = () =>
104+
{
105+
NavigationManager.NavigateTo(DashboardUrls.TracesUrl(resource: GetResourceName(Resource)));
106+
return Task.CompletedTask;
107+
},
108+
Tooltip = telemetryTooltip
109+
});
110+
_menuItems.Add(new MenuButtonItem
115111
{
116-
NavigationManager.NavigateTo(DashboardUrls.MetricsUrl(resource: GetResourceName(Resource)));
117-
return Task.CompletedTask;
118-
},
119-
Tooltip = telemetryTooltip,
120-
IsDisabled = !hasTelemetryApplication
121-
});
112+
Text = Loc[nameof(Resources.Resources.ResourceActionMetricsText)],
113+
Icon = s_metricsIcon,
114+
OnClick = () =>
115+
{
116+
NavigationManager.NavigateTo(DashboardUrls.MetricsUrl(resource: GetResourceName(Resource)));
117+
return Task.CompletedTask;
118+
},
119+
Tooltip = telemetryTooltip
120+
});
121+
}
122122

123123
// If display is desktop then we display highlighted commands next to the ... button.
124124
if (ViewportInformation.IsDesktop)

0 commit comments

Comments
 (0)