Make console log page usable on low-res/high-zoom #3776
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-codeflow
|
This breaks scrolling. Before (note extra control only causes the console area to be scrollable): After (scrolling includes the header): Can you put a little time into testing these kind of changes. Fixing the UX issue is a goal, but they shouldn't break regular usage of the app. |
JamesNK
requested changes
Apr 18, 2024
| display: grid; | ||
| grid-template-rows: auto auto 1fr; | ||
| height: 100%; | ||
| min-height: 100%; |
There was a problem hiding this comment.
What about this?
Suggested change
| min-height: 100%; | |
| height: 100%; | |
| min-height: 300px; |
dotnet-policy-service
bot
added
the
needs-author-action
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the console logs page is not usable for low-res/high-zoom users (e.g. 1280x1024, 400%) that we are required to support.
Before:
After:
After for 100%, higher res (no change)
Microsoft Reviewers: Open in CodeFlow