Skip to content

Conversation

@radical
Copy link
Member

@radical radical commented Aug 7, 2024

.. launchsettings fails. This matches the code in
DistributedApplicationFactory.GetLaunchSettings.

  • [playground] Fix CosmosEndToEnd.AppHost's launchsettings.json - trailing comma
Microsoft Reviewers: Open in CodeFlow

radical added 2 commits August 7, 2024 18:05
.. launchsettings fails. This matches the code in
`DistributedApplicationFactory.GetLaunchSettings`.
@radical radical requested a review from ReubenBond as a code owner August 7, 2024 22:17
@radical radical requested review from eerhardt and mitchdenny and removed request for ReubenBond and eerhardt August 7, 2024 22:17
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 7, 2024
@radical radical requested review from ReubenBond, eerhardt and mitchdenny and removed request for mitchdenny August 7, 2024 22:17
@radical radical added the area-app-testing Issues pertaining to the APIs in Aspire.Hosting.Testing label Aug 7, 2024
@radical
Copy link
Member Author

radical commented Aug 7, 2024

Should GetLaunchSettings be shared between Aspire.Hosting, and Aspire.Hosting.Testing? Most of it is the same.

@radical radical removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 7, 2024
@radical radical requested a review from sebastienros August 7, 2024 22:20
@eerhardt
Copy link
Member

eerhardt commented Aug 8, 2024

Should GetLaunchSettings be shared between Aspire.Hosting, and Aspire.Hosting.Testing? Most of it is the same.

Yes. Can you log an issue to combine these implementations into 1?

@radical
Copy link
Member Author

radical commented Aug 8, 2024

Should GetLaunchSettings be shared between Aspire.Hosting, and Aspire.Hosting.Testing? Most of it is the same.

Yes. Can you log an issue to combine these implementations into 1?

#5231

@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-testing Issues pertaining to the APIs in Aspire.Hosting.Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants