Update default container image name & tag generation #7472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Feb 7, 2025
| var fullyQualifiedDockerfilePath = Path.GetFullPath(dockerfilePath, fullyQualifiedContextPath); | ||
|
|
||
| var imageName = builder.GenerateImageName(); | ||
| var imageName = ImageNameGenerator.GenerateImageName(builder); |
Member
There was a problem hiding this comment.
Do we want to avoid overwriting the image name?
Member
Author
There was a problem hiding this comment.
Oh you mean if someone called WithImage before calling this?
davidfowl
approved these changes
Feb 7, 2025
github-actions
bot
added
the
area-app-model
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the generated container image name and tag used when calling
AddDockerfileorWithDockerfile. Name will now just be the resource name lowercased, and the tag will be a hash generated from the app host directory path and current timestamp.Fixes #7462
Checklist