Sync shared code from runtime (#22619)

github-actions[bot] · web-flow · commit 52fdd8f2a2f2 · 2020-06-08T20:17:43.000Z
Co-authored-by: github-actions[bot] &lt;41898282+github-actions[bot]@users.noreply.github.com&gt;
diff --git a/src/Shared/runtime/Quic/Implementations/MsQuic/Internal/MsQuicApi.cs b/src/Shared/runtime/Quic/Implementations/MsQuic/Internal/MsQuicApi.cs
@@ -223,7 +223,7 @@ internal unsafe uint UnsafeGetParam(
         public async ValueTask<MsQuicSecurityConfig?> CreateSecurityConfig(X509Certificate certificate, string? certFilePath, string? privateKeyFilePath)
         {
             MsQuicSecurityConfig? secConfig = null;
-            var tcs = new TaskCompletionSource<object?>(TaskCreationOptions.RunContinuationsAsynchronously);
+            var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
             uint secConfigCreateStatus = MsQuicStatusCodes.InternalError;
             uint createConfigStatus;
             IntPtr unmanagedAddr = IntPtr.Zero;
@@ -283,7 +283,7 @@ void SecCfgCreateCallbackHandler(
                 {
                     secConfig = new MsQuicSecurityConfig(this, securityConfig);
                     secConfigCreateStatus = status;
-                    tcs.SetResult(null);
+                    tcs.SetResult();
                 }
 
                 await tcs.Task.ConfigureAwait(false);

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ internal unsafe uint UnsafeGetParam(`
`223`	`223`	`public async ValueTask<MsQuicSecurityConfig?> CreateSecurityConfig(X509Certificate certificate, string? certFilePath, string? privateKeyFilePath)`
`224`	`224`	`{`
`225`	`225`	`MsQuicSecurityConfig? secConfig = null;`
`226`		`- var tcs = new TaskCompletionSource<object?>(TaskCreationOptions.RunContinuationsAsynchronously);`
	`226`	`+ var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);`
`227`	`227`	`uint secConfigCreateStatus = MsQuicStatusCodes.InternalError;`
`228`	`228`	`uint createConfigStatus;`
`229`	`229`	`IntPtr unmanagedAddr = IntPtr.Zero;`
`@@ -283,7 +283,7 @@ void SecCfgCreateCallbackHandler(`
`283`	`283`	`{`
`284`	`284`	`secConfig = new MsQuicSecurityConfig(this, securityConfig);`
`285`	`285`	`secConfigCreateStatus = status;`
`286`		`- tcs.SetResult(null);`
	`286`	`+ tcs.SetResult();`
`287`	`287`	`}`
`288`	`288`
`289`	`289`	`await tcs.Task.ConfigureAwait(false);`