Not able to skip aspnetcore testcases with Mono runtime

[ashutoshjadhav9]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

We were trying to skip the aspnetcore testcases with Mono runtime using FrameworkSkipCondition attribute like below

[ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task StartupAnalyzer_AuthNoRouting()
{

}

The testcase gets skipped when we use CoreCLR in FrameworkSkipCondition attribute instead of Mono

Expected Behavior

The testcase should get skipped with Mono when used in FrameworkSkipCondition attribute

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

Linking to issue dotnet/runtime#69823

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

[wtgodbe]

Looks like we only honor the skip attribute on Mono for NetFramework:

aspnetcore/src/Testing/src/xunit/FrameworkSkipConditionAttribute.cs

Lines 35 to 40 in 4f0174b

	#if NETFRAMEWORK
	if (excludedFrameworks.HasFlag(RuntimeFrameworks.Mono) &&
	TestPlatformHelper.IsMono)
	{
	return false;
	}

This is in our backlog right now so we won't get to it for a while, but if you want to open a PR to modify the code in the above file, it should be pretty trivial to fix it so we skip on mono for non-NetFramework tests as well.

[ivanpovazan]

@wtgodbe @tmds

If I understood correctly the test cases in question got disabled because of: dotnet/runtime#60650
The issue has been fixed via: dotnet/runtime#87406
So I think the tests can be enabled again.

Let me know if I can help in regard to that.

[tmds]

@ivanpovazan yes, the tests can be enabled again. To do that, the ActiveIssue attributes with the url https://github.com/dotnet/runtime/issues/60650 must be removed from the tests. Do you want to do that? Or should I look into it?

[ivanpovazan]

@ivanpovazan yes, the tests can be enabled again. To do that, the ActiveIssue attributes with the url https://github.com/dotnet/runtime/issues/60650 must be removed from the tests. Do you want to do that? Or should I look into it?

@tmds thank you, I have opened a PR: dotnet/runtime#88322

Is there anything that needs to be done on aspnetcore side?

[Sapana-Khemkar]

We have verified aspnetcore tests and now they are passing on mono. Thanks @ivanpovazan. I think we donot have to do anything on mono.