Fix use of bitwise '&' with boolean operands in palrt (#3349)

HJLeee · web-flow · commit 2e178a1dfa3d · 2022-09-05T10:07:35.000-07:00
diff --git a/src/shared/palrt/bstr.cpp b/src/shared/palrt/bstr.cpp
@@ -47,7 +47,7 @@ inline HRESULT CbSysStringSize(ULONG cchSize, BOOL isByteLen, ULONG *result)
     else
     {
         ULONG temp = 0; // should not use in-place addition in ULongAdd
-        if (SUCCEEDED(ULongMult(cchSize, sizeof(WCHAR), &temp)) &
+        if (SUCCEEDED(ULongMult(cchSize, sizeof(WCHAR), &temp)) &&
             SUCCEEDED(ULongAdd(temp, constant, result)))
         {
             *result = *result & ~WIN32_ALLOC_ALIGN;

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ inline HRESULT CbSysStringSize(ULONG cchSize, BOOL isByteLen, ULONG *result)`
`47`	`47`	`else`
`48`	`48`	`{`
`49`	`49`	`ULONG temp = 0; // should not use in-place addition in ULongAdd`
`50`		`- if (SUCCEEDED(ULongMult(cchSize, sizeof(WCHAR), &temp)) &`
	`50`	`+ if (SUCCEEDED(ULongMult(cchSize, sizeof(WCHAR), &temp)) &&`
`51`	`51`	`SUCCEEDED(ULongAdd(temp, constant, result)))`
`52`	`52`	`{`
`53`	`53`	`result = result & ~WIN32_ALLOC_ALIGN;`