Skip to content

Commit 437cf6f

Browse files
authored
Do not use arch-specific properties for stable/nonstable versions (#5486)
1 parent a3c354f commit 437cf6f

File tree

3 files changed

+9
-13
lines changed

3 files changed

+9
-13
lines changed

eng/InstallRuntimes.proj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
<PropertyGroup>
3737
<CommonInstallArgs>-NoPath -SkipNonVersionedFiles -Architecture $(BuildArch) -InstallDir $(DotNetInstallRoot)</CommonInstallArgs>
38-
<DotNetInstallDir>$([MSBuild]::NormalizeDirectory('$(DotNetInstallRoot)', 'shared', 'Microsoft.NETCore.App', '$(MicrosoftNETCoreAppRuntimewinx64Version)'))</DotNetInstallDir>
38+
<DotNetInstallDir>$([MSBuild]::NormalizeDirectory('$(DotNetInstallRoot)', 'shared', 'Microsoft.NETCore.App', '$(MicrosoftNETCoreAppRefVersion)'))</DotNetInstallDir>
3939
<TestConfigFileName>$(DotNetInstallRoot)Debugger.Tests.Versions.txt</TestConfigFileName>
4040
</PropertyGroup>
4141

@@ -103,7 +103,7 @@
103103
Condition="'$(LiveRuntimeDir)' != ''"
104104
Inputs="$(VersionsPropsPath)"
105105
Outputs="$(TestConfigFileName)">
106-
106+
107107
<ItemGroup>
108108
<_LiveRuntimeFiles Include="$(LiveRuntimeDir)\**\*.*" />
109109
</ItemGroup>

eng/Version.Details.xml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,7 @@
3535
<Uri>https://github.com/dotnet/dotnet</Uri>
3636
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
3737
</Dependency>
38-
<Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="10.0.0-preview.5.25229.109">
39-
<Uri>https://github.com/dotnet/dotnet</Uri>
40-
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
41-
</Dependency>
42-
<Dependency Name="VS.Redist.Common.NetCore.SharedFramework.x64.10.0" Version="10.0.0-preview.5.25229.109">
38+
<Dependency Name="Microsoft.NETCore.Platforms" Version="10.0.0-preview.5.25229.109">
4339
<Uri>https://github.com/dotnet/dotnet</Uri>
4440
<Sha>78c5fa9a48d469a19ab5a61c16c955c1f370b5be</Sha>
4541
</Dependency>

eng/Versions.props

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
</PropertyGroup>
1717
<PropertyGroup>
1818
<!-- Latest shared runtime version updated by darc -->
19-
<VSRedistCommonNetCoreSharedFrameworkx64100Version>10.0.0-preview.5.25229.109</VSRedistCommonNetCoreSharedFrameworkx64100Version>
20-
<MicrosoftNETCoreAppRuntimewinx64Version>10.0.0-preview.5.25229.109</MicrosoftNETCoreAppRuntimewinx64Version>
19+
<MicrosoftNETCorePlatformsVersion>10.0.0-preview.5.25229.109</MicrosoftNETCorePlatformsVersion>
20+
<MicrosoftNETCoreAppRefVersion>10.0.0-preview.5.25229.109</MicrosoftNETCoreAppRefVersion>
2121
<!-- Latest shared aspnetcore version updated by darc -->
2222
<MicrosoftAspNetCoreAppRefInternalVersion>10.0.0-preview.5.25229.109</MicrosoftAspNetCoreAppRefInternalVersion>
2323
<MicrosoftAspNetCoreAppRefVersion>10.0.0-preview.5.25229.109</MicrosoftAspNetCoreAppRefVersion>
@@ -114,8 +114,8 @@
114114
</PropertyGroup>
115115
<ItemGroup Condition="!$(PrivateBuildTesting) AND !$(InternalReleaseTesting)">
116116
<RuntimeTestVersions Include="Latest">
117-
<RuntimeDownload>$(VSRedistCommonNetCoreSharedFrameworkx64100Version)</RuntimeDownload>
118-
<Runtime>$(MicrosoftNETCoreAppRuntimewinx64Version)</Runtime>
117+
<RuntimeDownload>$(MicrosoftNETCorePlatformsVersion)</RuntimeDownload>
118+
<Runtime>$(MicrosoftNETCoreAppRefVersion)</Runtime>
119119
<AspNetDownload>$(MicrosoftAspNetCoreAppRefInternalVersion)</AspNetDownload>
120120
<AspNet>$(MicrosoftAspNetCoreAppRefVersion)</AspNet>
121121
<TargetFramework>net10.0</TargetFramework>
@@ -138,8 +138,8 @@
138138
<!-- Private build testing -->
139139
<ItemGroup Condition="$(PrivateBuildTesting)">
140140
<RuntimeTestVersions Include="Latest">
141-
<RuntimeDownload>$(VSRedistCommonNetCoreSharedFrameworkx64100Version)</RuntimeDownload>
142-
<Runtime>$(MicrosoftNETCoreAppRuntimewinx64Version)</Runtime>
141+
<RuntimeDownload>$(MicrosoftNETCorePlatformsVersion)</RuntimeDownload>
142+
<Runtime>$(MicrosoftNETCoreAppRefVersion)</Runtime>
143143
<AspNetDownload>$(MicrosoftAspNetCoreAppRefInternalVersion)</AspNetDownload>
144144
<AspNet>$(MicrosoftAspNetCoreAppRefVersion)</AspNet>
145145
<TargetFramework>net10.0</TargetFramework>

0 commit comments

Comments
 (0)