fix: Leader election failure to restart #783
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #677.
This pull request fixes the following behavioral issues noted when testing a leader-aware operator with transient network issues:
LeaderElectionBackgroundService, ifelector.RunUntilLeadershipLostAsync()throws, the exception is not observed in the library and no further attempts to become the leader occur. The library now logs any unexpected exceptions and tries to become the leader again.LeaderAwareResourceWatcher<TEntity>.StoppedLeadingwould erroneously pass a cancelled cancellation token toResourceWatcher<TEntity>. The library now passes theIHostApplicationLifetime.ApplicationStoppedtoken to theResourceWatcher<TEntity>- we can assume thatApplicationStoppedis a good indication that the stop should no longer be graceful.Due to the nature of these issues I've only been able to add test coverage in the form of unit tests.
I've tested these changes in practice using clumsy and an AKS cluster.