Skip to content

Commit 137eda5

Browse files
committed
Update tool to require .NET 6 / .NET Framework 4.6.1 at minimum.
This is needed otherwise it will try to require ".NET 2.0 Runtime" to be installed, which will cause roll forward to fail to load 6.0.0's System.Runtime when used on devices with newer versions of the .NET SDK and runtimes.
1 parent 44f1c24 commit 137eda5

File tree

9 files changed

+19
-16
lines changed

9 files changed

+19
-16
lines changed

src/EFCore.Tools/EFCore.Tools.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />
44

55
<PropertyGroup>
6-
<TargetFramework>netcoreapp2.0</TargetFramework>
6+
<TargetFramework>net6.0</TargetFramework>
77
<PackageId>Microsoft.EntityFrameworkCore.Tools</PackageId>
88
<NuspecFile>$(MSBuildThisFileDirectory)$(MSBuildProjectName).nuspec</NuspecFile>
99
<DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>

src/EFCore.Tools/EFCore.Tools.nuspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
<file src="../../artifacts/bin/ef/$configuration$/net461/ef.pdb" target="tools/net461/any/" />
2020
<file src="../../artifacts/bin/ef/x86/$configuration$/net461/ef.exe" target="tools/net461/win-x86/" />
2121
<file src="../../artifacts/bin/ef/x86/$configuration$/net461/ef.pdb" target="tools/net461/win-x86/" />
22-
<file src="../../artifacts/bin/ef/$configuration$/netcoreapp2.0/ef.dll" target="tools/netcoreapp2.0/any/" />
23-
<file src="../../artifacts/bin/ef/$configuration$/netcoreapp2.0/ef.pdb" target="tools/netcoreapp2.0/any/" />
24-
<file src="../../artifacts/bin/ef/$configuration$/netcoreapp2.0/ef.runtimeconfig.json" target="tools/netcoreapp2.0/any/" />
22+
<file src="../../artifacts/bin/ef/$configuration$/net6.0/ef.dll" target="tools/net6.0/any/" />
23+
<file src="../../artifacts/bin/ef/$configuration$/net6.0/ef.pdb" target="tools/net6.0/any/" />
24+
<file src="../../artifacts/bin/ef/$configuration$/net6.0/ef.runtimeconfig.json" target="tools/net6.0/any/" />
2525
</files>
2626
</package>

src/EFCore.Tools/tools/EntityFrameworkCore.psm1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1249,7 +1249,7 @@ function EF($project, $startupProject, $params, $applicationArgs, [switch] $skip
12491249
$projectAssetsFile = GetCpsProperty $startupProject 'ProjectAssetsFile'
12501250
$runtimeConfig = Join-Path $targetDir ($startupTargetName + '.runtimeconfig.json')
12511251
$runtimeFrameworkVersion = GetCpsProperty $startupProject 'RuntimeFrameworkVersion'
1252-
$efPath = Join-Path $PSScriptRoot 'netcoreapp2.0\any\ef.dll'
1252+
$efPath = Join-Path $PSScriptRoot 'net6.0\any\ef.dll'
12531253

12541254
$dotnetParams = 'exec', '--depsfile', $depsFile
12551255

src/dotnet-ef/RootCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ protected override int Execute(string[] _)
157157
args.Add(startupProject.RuntimeFrameworkVersion);
158158
}
159159

160-
args.Add(Path.Combine(toolsPath, "netcoreapp2.0", "any", "ef.dll"));
160+
args.Add(Path.Combine(toolsPath, "net6.0", "any", "ef.dll"));
161161
}
162162
else if (targetFramework.Identifier == ".NETStandard")
163163
{

src/dotnet-ef/dotnet-ef.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ dotnet ef dbcontext scaffold
1212
dotnet ef database drop
1313
dotnet ef database update
1414
</Description>
15-
<TargetFramework>netcoreapp3.1</TargetFramework>
15+
<TargetFramework>net6.0</TargetFramework>
1616
<OutputType>Exe</OutputType>
1717
<PackAsTool>true</PackAsTool>
1818
<PackAsToolShimRuntimeIdentifiers>win-x64;win-x86</PackAsToolShimRuntimeIdentifiers>
@@ -85,9 +85,9 @@ dotnet ef database update
8585

8686
<NuspecProperty Include="SettingsFile=$(_ToolsSettingsFilePath)" />
8787
<NuspecProperty Include="Output=$(PublishDir)**\*" />
88-
<NuspecProperty Include="OutputBinary=..\..\artifacts\bin\ef\$(Configuration)\netcoreapp2.0\ef.dll" />
89-
<NuspecProperty Include="OutputRuntimeConfig=..\..\artifacts\bin\ef\$(Configuration)\netcoreapp2.0\ef.runtimeconfig.json" />
90-
<NuspecProperty Include="OutputSymbol=..\..\artifacts\bin\ef\$(Configuration)\netcoreapp2.0\ef.pdb" />
88+
<NuspecProperty Include="OutputBinary=..\..\artifacts\bin\ef\$(Configuration)\net6.0\ef.dll" />
89+
<NuspecProperty Include="OutputRuntimeConfig=..\..\artifacts\bin\ef\$(Configuration)\net6.0\ef.runtimeconfig.json" />
90+
<NuspecProperty Include="OutputSymbol=..\..\artifacts\bin\ef\$(Configuration)\net6.0\ef.pdb" />
9191
<NuspecProperty Include="OutputExe=..\..\artifacts\bin\ef\$(Configuration)\net461\ef.exe" />
9292
<NuspecProperty Include="OutputExeSymbol=..\..\artifacts\bin\ef\$(Configuration)\net461\ef.pdb" />
9393
<NuspecProperty Include="OutputX86Exe=..\..\artifacts\bin\ef\x86\$(Configuration)\net461\ef.exe" />

src/dotnet-ef/dotnet-ef.nuspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
$CommonFileElements$
1212
<file src="$SettingsFile$" target="tools\$targetFramework$\any" />
1313
<file src="$Output$" target="tools\$targetFramework$\any" />
14-
<file src="$OutputBinary$" target="tools\$targetFramework$\any\tools\netcoreapp2.0\any" />
15-
<file src="$OutputRuntimeConfig$" target="tools\$targetFramework$\any\tools\netcoreapp2.0\any" />
16-
<file src="$OutputSymbol$" target="tools\$targetFramework$\any\tools\netcoreapp2.0\any" />
14+
<file src="$OutputBinary$" target="tools\$targetFramework$\any\tools\net6.0\any" />
15+
<file src="$OutputRuntimeConfig$" target="tools\$targetFramework$\any\tools\net6.0\any" />
16+
<file src="$OutputSymbol$" target="tools\$targetFramework$\any\tools\net6.0\any" />
1717
<file src="$OutputExe$" target="tools\$targetFramework$\any\tools\net461\any" />
1818
<file src="$OutputExeSymbol$" target="tools\$targetFramework$\any\tools\net461\any" />
1919
<file src="$OutputX86Exe$" target="tools\$targetFramework$\any\tools\net461\win-x86" />

src/ef/AppDomainOperationExecutor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public override void Dispose()
101101
}
102102
}
103103
}
104-
#elif NETCOREAPP2_0
104+
#elif NET6_0
105105
#else
106106
#error target frameworks need to be updated.
107107
#endif

src/ef/Commands/ProjectCommandBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ protected IOperationExecutor CreateExecutor(string[] remainingArguments)
106106
}
107107
}
108108
}
109-
#elif !NETCOREAPP2_0
109+
#elif !NET6_0
110110
#error target frameworks need to be updated.
111111
#endif
112112
return new ReflectionOperationExecutor(

src/ef/ef.csproj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>netcoreapp2.0;net461</TargetFrameworks>
4+
<TargetFrameworks>net6.0;net461</TargetFrameworks>
55
<Description>Entity Framework Core Command-line Tools</Description>
66
<OutputType>Exe</OutputType>
77
<IsPackable>false</IsPackable>
88
<RootNamespace>Microsoft.EntityFrameworkCore.Tools</RootNamespace>
99
<CheckEolTargetFramework>False</CheckEolTargetFramework>
1010
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)..\..\rulesets\EFCore.noxmldocs.ruleset</CodeAnalysisRuleSet>
11+
<RollForward>Major</RollForward>
12+
<!-- disable nullable warnings for now. -->
13+
<Nullable>annotations</Nullable>
1114
</PropertyGroup>
1215

1316
<ItemGroup>

0 commit comments

Comments
 (0)