Avoid using ^ and ~ on value-converted expressions

The transformation of equality/in-equality in a (negated) XOR is only possible
when the expressions are BIT or integer types on the SQL side (i.e. taking value
conversion into account).

Similarly, the Boolean negation `NOT` can be implemented as `~` only if the
underlying expression is a BIT.

Fixes #35093.

Author: ranma42

src/EFCore.SqlServer/Query/Internal/SearchConditionConverter.cs

@@ -206,9 +206,11 @@ protected virtual Expression VisitSqlBinary(SqlBinaryExpression binary, bool inS
 
         if (binary.OperatorType is ExpressionType.NotEqual or ExpressionType.Equal)
         {
+            var leftType = newLeft.TypeMapping?.Converter?.ProviderClrType ?? newLeft.Type;
+            var rightType = newRight.TypeMapping?.Converter?.ProviderClrType ?? newRight.Type;
             if (!inSearchConditionContext
-                && (newLeft.Type == typeof(bool) || newLeft.Type.IsEnum || newLeft.Type.IsInteger())
-                && (newRight.Type == typeof(bool) || newRight.Type.IsEnum || newRight.Type.IsInteger()))
+                && (leftType == typeof(bool) || leftType.IsInteger())
+                && (rightType == typeof(bool) || rightType.IsInteger()))
             {
                 // "lhs != rhs" is the same as "CAST(lhs ^ rhs AS BIT)", except that
                 // the first is a boolean, the second is a BIT
@@ -262,10 +264,13 @@ protected virtual Expression VisitSqlUnary(SqlUnaryExpression sqlUnaryExpression
 
         switch (sqlUnaryExpression.OperatorType)
         {
-            case ExpressionType.Not when sqlUnaryExpression.Type == typeof(bool):
+            case ExpressionType.Not
+                when (sqlUnaryExpression.TypeMapping?.Converter?.ProviderClrType ?? sqlUnaryExpression.Type) == typeof(bool):
             {
                 // when possible, avoid converting to/from predicate form
-                if (!inSearchConditionContext && sqlUnaryExpression.Operand is not (ExistsExpression or InExpression or LikeExpression))
+                if (!inSearchConditionContext &&
+                    sqlUnaryExpression.TypeMapping?.Converter is null &&
+                    sqlUnaryExpression.Operand is not (ExistsExpression or InExpression or LikeExpression))
                 {
                     var negatedOperand = (SqlExpression)Visit(sqlUnaryExpression.Operand);