ResourceManagerStringLocalizerFactory allocates too much

[sebastienros]

Here is an allocations snapshot for 50 requests of a sample web page rendering a blog post. It allocates more attributes than strings. More than 3MB of allocations for 50 requests (it depends on how many times the service is resolved).

The issue is in the Create method of this factory, which is called for every component that resolves an IStringLocalizer from DI, the result is cached, but creating the key of the cache entry is doing uncached reflection.

We could either cache by the type itself, or cache the reflection.

As part of the migration of components from dotnet/extensions to dotnet/runtime (aspnet/Announcements#411) we will be bulk closing some of the older issues. If you are still interested in having this issue addressed, just comment and the issue will be automatically reactivated (even if you aren't the author). When you do that, I'll page the team to come take a look. If you've moved on or workaround the issue and no longer need this change, just ignore this and the issue will be closed in 7 days.

If you know that the issue affects a package that has moved to a different repo, please consider re-opening the issue in that repo. If you're unsure, that's OK, someone from the team can help!