Skip to content

Fix Typo in test failure warning #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Fix Typo in test failure warning #2660

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
273051b
add 'No'
jtschuster Feb 25, 2022
db9d107
make plural
jtschuster Feb 25, 2022
c827328
empty commit, looks like a flaky CI failure
jtschuster Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ void VerifyLoggedMessages (AssemblyDefinition original, LinkerTestLogger logger,
foreach ((var attrProvider, var attr) in expectedNoWarningsAttributes) {
var unexpectedWarningCode = attr.ConstructorArguments.Count == 0 ? null : (string) attr.GetConstructorArgumentValue (0);
if (unexpectedWarningCode != null && !unexpectedWarningCode.StartsWith ("IL")) {
Assert.Fail ($"The warning code specified in ExpectedWarning attribute must start with the 'IL' prefix. Specified value: '{unexpectedWarningCode}'.");
Assert.Fail ($"The warning code specified in ExpectedNoWarnings attribute must start with the 'IL' prefix. Specified value: '{unexpectedWarningCode}'.");
}

int? unexpectedWarningCodeNumber = unexpectedWarningCode == null ? null : int.Parse (unexpectedWarningCode.Substring (2));
Expand Down