Skip to content

Conversation

@MattKotsenas
Copy link
Member

@MattKotsenas MattKotsenas commented Aug 27, 2024

In preparation for #46, add some test to validate the current package behavior. This doesn't test everything; future PRs should ensure the code they're changing is tested.

The test flow is as follows:

  1. Include DotNet.ReproducibleBuilds's own .props and .targets files into the test project's output
  2. Create a temp directory
  3. Create a {project}.*.props and {project}.*.targets file in the obj/ folder so that the .NET SDK will import the props and targets at the correct time (this is basically to do a NuGet restore of the project without needing to create the package or deal with package resolution)
  4. Create a temp project and assert the behavior

@MattKotsenas MattKotsenas requested a review from baronfel August 27, 2024 00:10
@MattKotsenas MattKotsenas force-pushed the feature/repositorybranch-net9 branch from 8a753e3 to 8f49df7 Compare August 27, 2024 00:16
@MattKotsenas MattKotsenas force-pushed the feature/repositorybranch-net9 branch from 8f49df7 to b18402c Compare August 27, 2024 00:21
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, no notes.

I really like that library - might have to bug @jeffkl and see if we can get it added to feeds that the SDK uses so we can migrate off our home-grown stuff :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants