Skip to content

Conversation

@Inurias
Copy link
Contributor

@Inurias Inurias commented Mar 25, 2025

Fixes #65921
Closes #67400

@Inurias Inurias requested a review from a team as a code owner March 25, 2025 23:07
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 25, 2025
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode labels Mar 25, 2025
@Inurias
Copy link
Contributor Author

Inurias commented Mar 25, 2025

@dotnet-policy-service agree

@Inurias
Copy link
Contributor Author

Inurias commented Mar 26, 2025

There are some tests failing that have code like this in their expected string:

namespace ConsoleApp185;
using System;
using System.Collections.Generic;

which would now be:

namespace ConsoleApp185;

using System;
using System.Collections.Generic;

How should these cases be handled? Do I update the expected strings in those tests?

@CyrusNajmabadi
Copy link
Member

o I update the expected strings in those tests?

Yup. We can review all the changes and make sure it matches our expectations. Thanks!

@Inurias
Copy link
Contributor Author

Inurias commented Mar 26, 2025

o I update the expected strings in those tests?

Yup. We can review all the changes and make sure it matches our expectations. Thanks!

Done :)

@Inurias
Copy link
Contributor Author

Inurias commented Apr 1, 2025

@CyrusNajmabadi is there anything else to do here?

@CyrusNajmabadi
Copy link
Member

Nope. Looks great. Thanks for the ping and for the contribution!

@CyrusNajmabadi CyrusNajmabadi merged commit ff34293 into dotnet:main Apr 2, 2025
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 2, 2025
@Inurias Inurias deleted the fix-67400-file-scoped-namespace-newline branch April 11, 2025 16:27
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

3 participants