Remove unused reference #78286
Merged
Remove unused reference #78286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Infrastructure
untriaged
davidwengier
approved these changes
Apr 23, 2025
ryzngard
pushed a commit
to dotnet/razor
that referenced
this pull request
Apr 24, 2025
Razor side needed after dotnet/roslyn#78286 .roslyn used to contain Microsoft.Extensions.ObjectPool.dll because of the transitive dependency and now it doesn't so it has to be packaged in the .razorExtension
ryzngard
pushed a commit
to ryzngard/razor
that referenced
this pull request
Apr 28, 2025
Razor side needed after dotnet/roslyn#78286 .roslyn used to contain Microsoft.Extensions.ObjectPool.dll because of the transitive dependency and now it doesn't so it has to be packaged in the .razorExtension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer used, which is fantastic! Less EA to worry about, fewer dual insertions, the whole 9 meters. However, it turns out it still happily restores and gets packaged in the LanguageServer for VS Code. Now that razor is on 10.x the 9.x version load will cause an exception when loading. It will eventually find the right version because it's packaged next to the source generator in the rzls package, but the exception is both alarming to users and slows things down. Let's fix that.
Fixes dotnet/vscode-csharp#8193