[mono] Reenable disabled tests as mono now respects non-public custom attributes in dynamic assemblies (#88322)

ivanpovazan · web-flow · commit 01c9a848915a · 2023-07-04T15:02:54.000+02:00
* Reenable disabled tests * Disable Roslyn analyzer tests in the browser as Monitor.Wait / Monitor.Pulse are not supported on single-threaded WASM Contributes to: #60650
diff --git a/src/libraries/System.Private.CoreLib/tests/IntrinsicsInSystemPrivatecoreLibAnalyzer.Tests/IntrinsicsInSystemPrivateCoreLibUnitTests.cs b/src/libraries/System.Private.CoreLib/tests/IntrinsicsInSystemPrivatecoreLibAnalyzer.Tests/IntrinsicsInSystemPrivateCoreLibUnitTests.cs
@@ -5,7 +5,7 @@
 
 namespace IntrinsicsInSystemPrivateCoreLib.Test
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
+    [SkipOnPlatform(TestPlatforms.Browser, "Do not try to run analyzer tests in the browser")]
     public class IntrinsicsInSystemPrivateCoreLibUnitTest
     {
         string BoilerPlate = @"
diff --git a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/AddGeneratedComClassTests.cs b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/AddGeneratedComClassTests.cs
@@ -9,7 +9,6 @@
 
 namespace ComInterfaceGenerator.Unit.Tests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class AddGeneratedComClassTests
     {
         [Fact]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComHostingDoesNotSupportGeneratedComInterfaceTests.cs b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComHostingDoesNotSupportGeneratedComInterfaceTests.cs
@@ -8,7 +8,6 @@
 
 namespace ComInterfaceGenerator.Unit.Tests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class ComHostingDoesNotSupportGeneratedComInterfaceTests
     {
         [InlineData(true)]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ConvertToGeneratedComInterfaceTests.cs b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ConvertToGeneratedComInterfaceTests.cs
@@ -9,7 +9,6 @@
 
 namespace ComInterfaceGenerator.Unit.Tests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class ConvertToGeneratedComInterfaceTests
     {
         [Fact]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/GeneratedComInterfaceAnalyzerTests.cs b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/GeneratedComInterfaceAnalyzerTests.cs
@@ -11,7 +11,6 @@
 
 namespace ComInterfaceGenerator.Unit.Tests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class GeneratedComInterfaceAnalyzerTests
     {
         static string _usings = $$"""
@@ -21,7 +20,6 @@ public class GeneratedComInterfaceAnalyzerTests
             #pragma warning restore CS8019
             """;
 
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
         public class InterfaceHasInterfaceTypeAttributeOnly
         {
             [Fact]
@@ -143,7 +141,6 @@ void Bar() {}
             }
         }
 
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
         public class InterfaceHasGeneratedComInterfaceAttributeOnly
         {
             [Fact]
@@ -162,7 +159,6 @@ void Bar() {}
             }
         }
 
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
         public class InterfaceHasGeneratedComInterfaceAttributeAndInterfaceTypeAttribute
         {
             [Fact]
@@ -318,7 +314,6 @@ await VerifyCS.VerifyAnalyzerAsync(
             }
         }
 
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
         public class PartialInterfaceHasGeneratedComInterfaceAttributeAndInterfaceTypeAttribute
         {
             [Fact]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/RuntimeComApiUsageWithSourceGeneratedComTests.cs b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/RuntimeComApiUsageWithSourceGeneratedComTests.cs
@@ -10,7 +10,6 @@
 
 namespace ComInterfaceGenerator.Unit.Tests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class RuntimeComApiUsageWithSourceGeneratedComTests
     {
         [Fact]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/AddDisableRuntimeMarshallingAttributeFixerTests.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/AddDisableRuntimeMarshallingAttributeFixerTests.cs
@@ -16,7 +16,6 @@
 
 namespace LibraryImportGenerator.UnitTests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class AddDisableRuntimeMarshallingAttributeFixerTests
     {
         [Fact]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/ConvertToLibraryImportAnalyzerTests.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/ConvertToLibraryImportAnalyzerTests.cs
@@ -14,7 +14,6 @@
 
 namespace LibraryImportGenerator.UnitTests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class ConvertToLibraryImportAnalyzerTests
     {
         public static IEnumerable<object[]> MarshallingRequiredTypes() => new[]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/ConvertToLibraryImportFixerTests.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/ConvertToLibraryImportFixerTests.cs
@@ -19,7 +19,6 @@
 
 namespace LibraryImportGenerator.UnitTests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class ConvertToLibraryImportFixerTests
     {
         private const string ConvertToLibraryImportKey = "ConvertToLibraryImport";
diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_AttributeUsage.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_AttributeUsage.cs
@@ -15,7 +15,6 @@
 
 namespace LibraryImportGenerator.UnitTests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class CustomMarshallerAttributeAnalyzerTests_AttributeUsage
     {
         [Fact]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs
@@ -15,7 +15,6 @@
 
 namespace LibraryImportGenerator.UnitTests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class CustomMarshallerAttributeAnalyzerTests_StatefulLinearCollectionShapeValidation
     {
         [Fact]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs
@@ -16,7 +16,6 @@
 
 namespace LibraryImportGenerator.UnitTests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class CustomMarshallerAttributeAnalyzerTests_StatefulValueShapeValidation
     {
         [Fact]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs
@@ -15,7 +15,6 @@
 
 namespace LibraryImportGenerator.UnitTests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class CustomMarshallerAttributeAnalyzerTests_StatelessLinearCollectionShapeValidation
     {
         [Fact]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs
@@ -15,7 +15,6 @@
 
 namespace LibraryImportGenerator.UnitTests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class CustomMarshallerAttributeAnalyzerTests_StatelessValueShapeValidation
     {
         [Fact]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/NativeMarshallingAttributeAnalyzerTests.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/NativeMarshallingAttributeAnalyzerTests.cs
@@ -13,7 +13,6 @@
 
 namespace LibraryImportGenerator.UnitTests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class NativeMarshallingAttributeAnalyzerTests
     {
         [Fact]
diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/ShapeBreakingDiagnosticSuppressorTests.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/ShapeBreakingDiagnosticSuppressorTests.cs
@@ -17,7 +17,6 @@
 
 namespace LibraryImportGenerator.UnitTests
 {
-    [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]
     public class ShapeBreakingDiagnosticSuppressorTests
     {
         [Fact]

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`
`6`	`6`	`namespace IntrinsicsInSystemPrivateCoreLib.Test`
`7`	`7`	`{`
`8`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
	`8`	`+ [SkipOnPlatform(TestPlatforms.Browser, "Do not try to run analyzer tests in the browser")]`
`9`	`9`	`public class IntrinsicsInSystemPrivateCoreLibUnitTest`
`10`	`10`	`{`
`11`	`11`	`string BoilerPlate = @"`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@`
`9`	`9`
`10`	`10`	`namespace ComInterfaceGenerator.Unit.Tests`
`11`	`11`	`{`
`12`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`13`	`12`	`public class AddGeneratedComClassTests`
`14`	`13`	`{`
`15`	`14`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@`
`8`	`8`
`9`	`9`	`namespace ComInterfaceGenerator.Unit.Tests`
`10`	`10`	`{`
`11`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`12`	`11`	`public class ComHostingDoesNotSupportGeneratedComInterfaceTests`
`13`	`12`	`{`
`14`	`13`	`[InlineData(true)]`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@`
`11`	`11`
`12`	`12`	`namespace ComInterfaceGenerator.Unit.Tests`
`13`	`13`	`{`
`14`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`15`	`14`	`public class GeneratedComInterfaceAnalyzerTests`
`16`	`15`	`{`
`17`	`16`	`static string _usings = $$"""`
`@@ -21,7 +20,6 @@ public class GeneratedComInterfaceAnalyzerTests`
`21`	`20`	`#pragma warning restore CS8019`
`22`	`21`	`""";`
`23`	`22`
`24`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`25`	`23`	`public class InterfaceHasInterfaceTypeAttributeOnly`
`26`	`24`	`{`
`27`	`25`	`[Fact]`
`@@ -143,7 +141,6 @@ void Bar() {}`
`143`	`141`	`}`
`144`	`142`	`}`
`145`	`143`
`146`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`147`	`144`	`public class InterfaceHasGeneratedComInterfaceAttributeOnly`
`148`	`145`	`{`
`149`	`146`	`[Fact]`
`@@ -162,7 +159,6 @@ void Bar() {}`
`162`	`159`	`}`
`163`	`160`	`}`
`164`	`161`
`165`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`166`	`162`	`public class InterfaceHasGeneratedComInterfaceAttributeAndInterfaceTypeAttribute`
`167`	`163`	`{`
`168`	`164`	`[Fact]`
`@@ -318,7 +314,6 @@ await VerifyCS.VerifyAnalyzerAsync(`
`318`	`314`	`}`
`319`	`315`	`}`
`320`	`316`
`321`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`322`	`317`	`public class PartialInterfaceHasGeneratedComInterfaceAttributeAndInterfaceTypeAttribute`
`323`	`318`	`{`
`324`	`319`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@`
`10`	`10`
`11`	`11`	`namespace ComInterfaceGenerator.Unit.Tests`
`12`	`12`	`{`
`13`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`14`	`13`	`public class RuntimeComApiUsageWithSourceGeneratedComTests`
`15`	`14`	`{`
`16`	`15`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@`
`16`	`16`
`17`	`17`	`namespace LibraryImportGenerator.UnitTests`
`18`	`18`	`{`
`19`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`20`	`19`	`public class AddDisableRuntimeMarshallingAttributeFixerTests`
`21`	`20`	`{`
`22`	`21`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@`
`14`	`14`
`15`	`15`	`namespace LibraryImportGenerator.UnitTests`
`16`	`16`	`{`
`17`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`18`	`17`	`public class ConvertToLibraryImportAnalyzerTests`
`19`	`18`	`{`
`20`	`19`	`public static IEnumerable<object[]> MarshallingRequiredTypes() => new[]`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@`
`19`	`19`
`20`	`20`	`namespace LibraryImportGenerator.UnitTests`
`21`	`21`	`{`
`22`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`23`	`22`	`public class ConvertToLibraryImportFixerTests`
`24`	`23`	`{`
`25`	`24`	`private const string ConvertToLibraryImportKey = "ConvertToLibraryImport";`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`
`16`	`16`	`namespace LibraryImportGenerator.UnitTests`
`17`	`17`	`{`
`18`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60650", TestRuntimes.Mono)]`
`19`	`18`	`public class CustomMarshallerAttributeAnalyzerTests_AttributeUsage`
`20`	`19`	`{`
`21`	`20`	`[Fact]`