JIT: remove crossgen assert when embedding class handle (#52453)

AndyAyersMS · web-flow · commit 28cff50994cf · 2021-05-07T15:01:08.000-07:00
#52210 requires class handle embedding that crossgen does not support. Remove an assert as this is now an area where crossgen2 and crossgen diverge. Resolves #52450.
diff --git a/src/coreclr/zap/zapinfo.cpp b/src/coreclr/zap/zapinfo.cpp
@@ -1577,7 +1577,10 @@ CORINFO_CLASS_HANDLE ZapInfo::embedClassHandle(CORINFO_CLASS_HANDLE handle,
 
     if (IsReadyToRunCompilation())
     {
-        _ASSERTE(!"embedClassHandle");
+        // This is supported by crossgen2
+        if (m_zapper->m_pOpt->m_verbose)
+            m_zapper->Warning(W("ReadyToRun: embedding class handle not supported\n"));
+
         ThrowHR(E_NOTIMPL);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1577,7 +1577,10 @@ CORINFO_CLASS_HANDLE ZapInfo::embedClassHandle(CORINFO_CLASS_HANDLE handle,`
`1577`	`1577`
`1578`	`1578`	`if (IsReadyToRunCompilation())`
`1579`	`1579`	`{`
`1580`		`- _ASSERTE(!"embedClassHandle");`
	`1580`	`+ // This is supported by crossgen2`
	`1581`	`+ if (m_zapper->m_pOpt->m_verbose)`
	`1582`	`+ m_zapper->Warning(W("ReadyToRun: embedding class handle not supported\n"));`
	`1583`	`+`
`1581`	`1584`	`ThrowHR(E_NOTIMPL);`
`1582`	`1585`	`}`
`1583`	`1586`