[wasm] GenerateWasmBootJson - close file handles (#85482)

github-actions[bot] · radical · web-flow · commit 37d789bd296f · 2023-04-27T19:02:49.000-06:00
Close files opened with `File.OpenRead` by utilizing the `using`
pattern.

Co-authored-by: Ankit Jain &lt;radical@gmail.com&gt;
diff --git a/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/GenerateWasmBootJson.cs b/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/GenerateWasmBootJson.cs
@@ -290,7 +290,8 @@ public void WriteBootJson(Stream output, string entryAssemblyName)
             foreach (var configExtension in Extensions)
             {
                 var key = configExtension.GetMetadata("key");
-                var config = (Dictionary<string, object>)configSerializer.ReadObject(File.OpenRead(configExtension.ItemSpec));
+                using var fs = File.OpenRead(configExtension.ItemSpec);
+                var config = (Dictionary<string, object>)configSerializer.ReadObject(fs);
                 result.extensions[key] = config;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,8 @@ public void WriteBootJson(Stream output, string entryAssemblyName)`
`290`	`290`	`foreach (var configExtension in Extensions)`
`291`	`291`	`{`
`292`	`292`	`var key = configExtension.GetMetadata("key");`
`293`		`- var config = (Dictionary<string, object>)configSerializer.ReadObject(File.OpenRead(configExtension.ItemSpec));`
	`293`	`+ using var fs = File.OpenRead(configExtension.ItemSpec);`
	`294`	`+ var config = (Dictionary<string, object>)configSerializer.ReadObject(fs);`
`294`	`295`	`result.extensions[key] = config;`
`295`	`296`	`}`
`296`	`297`	`}`