Enabling CA1416

Author: tannergooding

eng/CodeAnalysis.ruleset

@@ -64,7 +64,6 @@
       <Rule Id="CA1308" Action="None" />             <!-- Normalize strings to uppercase -->
       <Rule Id="CA1309" Action="None" />             <!-- Use ordinal stringcomparison -->
       <Rule Id="CA1401" Action="Warning" />          <!-- P/Invokes should not be visible -->
-      <Rule Id="CA1416" Action="None" />             <!-- Validate platform compatibility; https://github.com/dotnet/runtime/issues/41354 -->
       <Rule Id="CA1417" Action="Warning" />          <!-- Do not use 'OutAttribute' on string parameters for P/Invokes -->
       <Rule Id="CA1501" Action="None" />             <!-- Avoid excessive inheritance -->
       <Rule Id="CA1502" Action="None" />             <!-- Avoid excessive complexity -->

src/libraries/Common/src/Interop/Windows/NCrypt/Interop.Properties.cs

@@ -1,9 +1,11 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System;
+using System.Diagnostics;
 using System.Runtime.InteropServices;
+using System.Runtime.Versioning;
 using System.Security.Cryptography;
-using System.Diagnostics;
 
 using Microsoft.Win32.SafeHandles;
 
@@ -17,6 +19,7 @@ internal static partial class NCrypt
         [DllImport(Interop.Libraries.NCrypt, CharSet = CharSet.Unicode)]
         internal static extern unsafe ErrorCode NCryptSetProperty(SafeNCryptHandle hObject, string pszProperty, [In] void* pbInput, int cbInput, CngPropertyOptions dwFlags);
 
+        [SupportedOSPlatform("windows")]
         internal static ErrorCode NCryptGetByteProperty(SafeNCryptHandle hObject, string pszProperty, ref byte result, CngPropertyOptions options = CngPropertyOptions.None)
         {
             int cbResult;
@@ -53,6 +56,8 @@ internal static ErrorCode NCryptGetIntProperty(SafeNCryptHandle hObject, string
             {
                 fixed (int* pResult = &result)
                 {
+                    Debug.Assert(OperatingSystem.IsWindows());
+
                     errorCode = Interop.NCrypt.NCryptGetProperty(
                         hObject,
                         pszProperty,

src/libraries/Common/src/Interop/Windows/WinSock/SafeNativeOverlapped.cs

@@ -57,6 +57,7 @@ private void FreeNativeOverlapped()
             {
                 unsafe
                 {
+                    Debug.Assert(OperatingSystem.IsWindows());
                     Debug.Assert(_socketHandle != null, "_socketHandle is null.");
 
                     ThreadPoolBoundHandle? boundHandle = _socketHandle.IOCPBoundHandle;

src/libraries/Common/src/System/Net/ContextAwareResult.Windows.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 #nullable enable
+using System.Diagnostics;
 using System.Security.Principal;
 
 namespace System.Net
@@ -13,13 +14,15 @@ internal partial class ContextAwareResult
         // Security: We need an assert for a call into WindowsIdentity.GetCurrent.
         private void SafeCaptureIdentity()
         {
+            Debug.Assert(OperatingSystem.IsWindows());
             _windowsIdentity = WindowsIdentity.GetCurrent();
         }
 
         private void CleanupInternal()
         {
             if (_windowsIdentity != null)
             {
+                Debug.Assert(OperatingSystem.IsWindows());
                 _windowsIdentity.Dispose();
                 _windowsIdentity = null;
             }

src/libraries/Microsoft.Extensions.Logging.EventLog/src/EventLogLogger.cs

@@ -164,6 +164,8 @@ private void WriteMessage(string message, EventLogEntryType eventLogEntryType, i
             }
         }
 
+#pragma warning disable CA1416 // Debug.Assert(OperatingSystem.IsWindows()) is not available
+
         private EventLogEntryType GetEventLogEntryType(LogLevel level)
         {
             switch (level)
@@ -181,5 +183,7 @@ private EventLogEntryType GetEventLogEntryType(LogLevel level)
                     return EventLogEntryType.Information;
             }
         }
+
+#pragma warning restore CA1416 // Debug.Assert(OperatingSystem.IsWindows()) is not available
     }
 }

src/libraries/Microsoft.Extensions.Logging.EventLog/src/WindowsEventLog.cs

@@ -4,9 +4,12 @@
 using System;
 using System.Diagnostics;
 using System.Security;
+using System.Runtime.Versioning;
 
 namespace Microsoft.Extensions.Logging.EventLog
 {
+#pragma warning disable CA1416 // Debug.Assert(OperatingSystem.IsWindows()) is not available
+
     internal class WindowsEventLog : IEventLog
     {
         // https://msdn.microsoft.com/EN-US/library/windows/desktop/aa363679.aspx
@@ -52,4 +55,6 @@ public void WriteEntry(string message, EventLogEntryType type, int eventID, shor
             }
         }
     }
+
+#pragma warning restore CA1416 // Debug.Assert(OperatingSystem.IsWindows()) is not available
 }

src/libraries/System.Drawing.Common/src/System/Drawing/Icon.Windows.cs

@@ -657,6 +657,7 @@ public void Save(Stream outputStream)
                     }
                     finally
                     {
+                        Debug.Assert(OperatingSystem.IsWindows());
                         Marshal.ReleaseComObject(picture);
                     }
                 }

src/libraries/System.Drawing.Common/src/System/Drawing/Internal/SystemColorTracker.cs

@@ -39,6 +39,7 @@ internal static void Add(ISystemColorTracker obj)
 
                 if (!addedTracker)
                 {
+                    Debug.Assert(OperatingSystem.IsWindows());
                     addedTracker = true;
                     SystemEvents.UserPreferenceChanged += new UserPreferenceChangedEventHandler(OnUserPreferenceChanged);
                 }
@@ -131,6 +132,7 @@ private static void GarbageCollectList()
 
         private static void OnUserPreferenceChanged(object sender, UserPreferenceChangedEventArgs e)
         {
+            Debug.Assert(OperatingSystem.IsWindows());
 
             // Update pens and brushes
             if (e.Category == UserPreferenceCategory.Color)

src/libraries/System.IO.Ports/src/System/IO/Ports/SerialPort.Win32.cs

@@ -3,6 +3,7 @@
 
 using Microsoft.Win32;
 using System.ComponentModel;
+using System.Diagnostics;
 
 namespace System.IO.Ports
 {
@@ -17,6 +18,8 @@ public static string[] GetPortNames()
             //
             // QueryDosDevice involves finding any ports that map to \Device\Serialx (call with null to get all, then iterate to get the actual device name)
 
+#pragma warning disable CA1416 // Debug.Assert(OperatingSystem.IsWindows()) is not available
+
             using (RegistryKey serialKey = Registry.LocalMachine.OpenSubKey(@"HARDWARE\DEVICEMAP\SERIALCOMM"))
             {
                 if (serialKey != null)
@@ -31,6 +34,8 @@ public static string[] GetPortNames()
                 }
             }
 
+#pragma warning restore CA1416 // Debug.Assert(OperatingSystem.IsWindows()) is not available
+
             return Array.Empty<string>();
         }
     }

src/libraries/System.Net.Sockets/src/System/Net/Sockets/BaseOverlappedAsyncResult.Windows.cs

@@ -50,6 +50,7 @@ internal void SetUnmanagedStructures(object? objectsToPin)
 
             unsafe
             {
+                Debug.Assert(OperatingSystem.IsWindows());
                 NativeOverlapped* overlapped = boundHandle.AllocateNativeOverlapped(s_ioCallback, this, objectsToPin);
                 _nativeOverlapped = new SafeNativeOverlapped(s.SafeHandle, overlapped);
             }
@@ -59,6 +60,7 @@ internal void SetUnmanagedStructures(object? objectsToPin)
 
         private static unsafe void CompletionPortCallback(uint errorCode, uint numBytes, NativeOverlapped* nativeOverlapped)
         {
+            Debug.Assert(OperatingSystem.IsWindows());
             BaseOverlappedAsyncResult asyncResult = (BaseOverlappedAsyncResult)ThreadPoolBoundHandle.GetNativeOverlappedState(nativeOverlapped)!;
 
             if (asyncResult.InternalPeekCompleted)