Enable CertificateCallbackThrowPropagates on Alpine (#105489)

liveans · web-flow · commit 5d6f36f8e61a · 2024-07-30T12:31:09.000+02:00
* Enable CertificateCallbackThrowPropagates

* Skip Test on platforms other than Alpine

* Review feedback

* Change condition to check MsQuic Version instead of Specific Distro

* Delete unused property
diff --git a/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs b/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs
@@ -52,6 +52,7 @@ public class MsQuicTests : QuicTestBase, IClassFixture<CertificateSetup>
     {
         private static byte[] s_data = "Hello world!"u8.ToArray();
         readonly CertificateSetup _certificates;
+        static bool SupportsAsyncCertValidation => QuicTestCollection.MsQuicVersion >= new Version(2, 4);
 
         public MsQuicTests(ITestOutputHelper output, CertificateSetup setup) : base(output)
         {
@@ -353,7 +354,7 @@ public async Task UntrustedClientCertificateFails()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/99074")]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/99074", typeof(MsQuicTests), nameof(SupportsAsyncCertValidation))]
         public async Task CertificateCallbackThrowPropagates()
         {
             using CancellationTokenSource cts = new CancellationTokenSource(PassingTestTimeout);

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ public class MsQuicTests : QuicTestBase, IClassFixture<CertificateSetup>`
`52`	`52`	`{`
`53`	`53`	`private static byte[] s_data = "Hello world!"u8.ToArray();`
`54`	`54`	`readonly CertificateSetup _certificates;`
	`55`	`+ static bool SupportsAsyncCertValidation => QuicTestCollection.MsQuicVersion >= new Version(2, 4);`
`55`	`56`
`56`	`57`	`public MsQuicTests(ITestOutputHelper output, CertificateSetup setup) : base(output)`
`57`	`58`	`{`
`@@ -353,7 +354,7 @@ public async Task UntrustedClientCertificateFails()`
`353`	`354`	`}`
`354`	`355`
`355`	`356`	`[Fact]`
`356`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/99074")]`
	`357`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/99074", typeof(MsQuicTests), nameof(SupportsAsyncCertValidation))]`
`357`	`358`	`public async Task CertificateCallbackThrowPropagates()`
`358`	`359`	`{`
`359`	`360`	`using CancellationTokenSource cts = new CancellationTokenSource(PassingTestTimeout);`