PR feedback

Author: PranavSenthilnathan

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/MLDsa/MLDsaTests.cs

@@ -32,8 +32,7 @@ public static void IsSupported_AgreesWithPlatform()
             Assert.Equal(PlatformSupportsMLDsa(), MLDsa.IsSupported);
         }
 
-        private static bool PlatformSupportsMLDsa()
-            => PlatformDetection.IsOpenSslSupported && PlatformDetection.OpenSslVersion >= new Version(3, 5);
+        private static bool PlatformSupportsMLDsa() => PlatformDetection.IsOpenSsl3_5;
 
         [Fact]
         public static void DisposeIsCalledOnImplementation()

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaPlatformTests.cs

@@ -14,15 +14,7 @@ public static void IsSupported_AgreesWithPlatform()
             Assert.Equal(PlatformSupportsSlhDsa(), SlhDsa.IsSupported);
         }
 
-        private static bool PlatformSupportsSlhDsa()
-        {
-            if (PlatformDetection.IsOpenSsl3_5)
-            {
-                return true;
-            }
-
-            return false;
-        }
+        private static bool PlatformSupportsSlhDsa() => PlatformDetection.IsOpenSsl3_5;
 
         [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
         public static void IsSupported_InitializesCrypto()

src/libraries/Common/tests/System/Security/Cryptography/MLKemImplementationTests.cs

@@ -53,14 +53,6 @@ public static void IsSupported_AgreesWithPlatform()
             Assert.Equal(PlatformSupportsMLKem(), MLKem.IsSupported);
         }
 
-        private static bool PlatformSupportsMLKem()
-        {
-            if (PlatformDetection.IsOpenSsl3_5)
-            {
-                return true;
-            }
-
-            return false;
-        }
+        private static bool PlatformSupportsMLKem() => PlatformDetection.IsOpenSsl3_5;
     }
 }

src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_slh_dsa.c

@@ -214,9 +214,9 @@ int32_t CryptoNative_SlhDsaGetPalId(const EVP_PKEY* pKey, int32_t* slhDsaTypeId)
     {
         ERR_clear_error();
 
-        // TODO: This conditional chain seems unavoidable. If there are multiple synonyms for a given key,
+        // This conditional chain seems unavoidable. If there are multiple synonyms for a given key,
         // then the provider determines which one will be returned from EVP_PKEY_get0_type_name.
-        // We don't have to worry about this if we use EVP_PKEY_is_a check instead.
+        // We use EVP_PKEY_is_a here instead to avoid this issue.
         if (EVP_PKEY_is_a(pKey, "SLH-DSA-SHA2-128s"))
         {
             *slhDsaTypeId = PalSlhDsaId_Sha2_128s;