fix Alpine build break (#101302)

lambdageek · web-flow · commit 907eff84ef20 · 2024-04-19T15:36:22.000-07:00
Apline defines NULL as std::nullptr which is not comparable/assignable with intptr_t Fixes dotnet/source-build#4345
diff --git a/src/coreclr/debug/daccess/cdac.cpp b/src/coreclr/debug/daccess/cdac.cpp
@@ -48,7 +48,7 @@ CDAC::CDAC(HMODULE module, uint64_t descriptorAddr, ICorDebugDataTarget* target)
 {
     if (m_module == NULL)
     {
-        m_cdac_handle = NULL;
+        m_cdac_handle = 0;
         return;
     }
 
@@ -62,7 +62,7 @@ CDAC::CDAC(HMODULE module, uint64_t descriptorAddr, ICorDebugDataTarget* target)
 
 CDAC::~CDAC()
 {
-    if (m_cdac_handle != NULL)
+    if (m_cdac_handle)
     {
         decltype(&cdac_reader_free) free = reinterpret_cast<decltype(&cdac_reader_free)>(::GetProcAddress(m_module, "cdac_reader_free"));
         _ASSERTE(free != nullptr);

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ CDAC::CDAC(HMODULE module, uint64_t descriptorAddr, ICorDebugDataTarget* target)`
`48`	`48`	`{`
`49`	`49`	`if (m_module == NULL)`
`50`	`50`	`{`
`51`		`- m_cdac_handle = NULL;`
	`51`	`+ m_cdac_handle = 0;`
`52`	`52`	`return;`
`53`	`53`	`}`
`54`	`54`
`@@ -62,7 +62,7 @@ CDAC::CDAC(HMODULE module, uint64_t descriptorAddr, ICorDebugDataTarget* target)`
`62`	`62`
`63`	`63`	`CDAC::~CDAC()`
`64`	`64`	`{`
`65`		`- if (m_cdac_handle != NULL)`
	`65`	`+ if (m_cdac_handle)`
`66`	`66`	`{`
`67`	`67`	`decltype(&cdac_reader_free) free = reinterpret_cast<decltype(&cdac_reader_free)>(::GetProcAddress(m_module, "cdac_reader_free"));`
`68`	`68`	`_ASSERTE(free != nullptr);`