Simplify RuntimeType.SplitName (#96991)

lilinus · web-flow · commit a77c0b4548e0 · 2024-01-15T09:23:05.000-08:00
diff --git a/src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs b/src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
@@ -2046,11 +2046,7 @@ private static void SplitName(string? fullname, out string? name, out string? ns
             if (nsDelimiter >= 0)
             {
                 ns = fullname.Substring(0, nsDelimiter);
-                int nameLength = fullname.Length - ns.Length - 1;
-                if (nameLength != 0)
-                    name = fullname.Substring(nsDelimiter + 1, nameLength);
-                else
-                    name = "";
+                name = fullname.Substring(nsDelimiter + 1);
                 Debug.Assert(fullname.Equals(ns + "." + name));
             }
             else

Original file line number	Diff line number	Diff line change
`@@ -2046,11 +2046,7 @@ private static void SplitName(string? fullname, out string? name, out string? ns`
`2046`	`2046`	`if (nsDelimiter >= 0)`
`2047`	`2047`	`{`
`2048`	`2048`	`ns = fullname.Substring(0, nsDelimiter);`
`2049`		`- int nameLength = fullname.Length - ns.Length - 1;`
`2050`		`- if (nameLength != 0)`
`2051`		`- name = fullname.Substring(nsDelimiter + 1, nameLength);`
`2052`		`- else`
`2053`		`- name = "";`
	`2049`	`+ name = fullname.Substring(nsDelimiter + 1);`
`2054`	`2050`	`Debug.Assert(fullname.Equals(ns + "." + name));`
`2055`	`2051`	`}`
`2056`	`2052`	`else`